WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#9567 closed defect (bug) (fixed)

The pubDate in rss/channel in feed-rss2-comments.php prevents the feed from being cached

Reported by: peaceablewhale Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.8
Component: Feeds Keywords: has-patch tested commit
Focuses: Cc:

Description

Currently, the pubDate of the feed is always a new timestamp. This prevents the feed from being cached.

Attachments (1)

9567.patch (820 bytes) - added by peaceablewhale 5 years ago.

Download all attachments as: .zip

Change History (7)

peaceablewhale5 years ago

comment:1 peaceablewhale5 years ago

  • Keywords has-patch added

comment:2 Denis-de-Bernardy5 years ago

  • Keywords commit added

comment:3 Denis-de-Bernardy5 years ago

  • Keywords commit removed

does the spec say either elt is required?

comment:4 peaceablewhale5 years ago

Both of the pubDate and lastBuildDate elements are optional, but the common practice is to use lastBuildDate (Blogger, Typepad, MovableType). The meaning of "lastBuildDate" is also more suitable here.

comment:5 Denis-de-Bernardy5 years ago

  • Keywords tested commit added

I take it that the headers are looked into for caching, but +1 on the semantics.

comment:6 ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11205]) Proper lastBuildDate for rss2 comments feed. Props peaceablewhale. fixes #9567

Note: See TracTickets for help on using tickets.