WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#9583 closed defect (bug) (fixed)

Missing hook for comments custom column management

Reported by: sirzooro Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.7.1
Component: General Keywords: has-patch tested
Focuses: Cc:

Description

Current WP version (2.7.1) doesn't have hooks for generation contents of custom columns on following pages: Comments, Categories, Link Categories, Tags, Users. On this this page, I found that fixes for all but 1st one (for Comments) are already in SVN and in nightly builds (I checked this).

I have created patch for this missing hook.

Attachments (2)

template.php.diff (435 bytes) - added by sirzooro 5 years ago.
9583.diff (1.2 KB) - added by coffee2code 5 years ago.
Same as original patch but based on diff from root of trunk and against latest rev ( r11001)

Download all attachments as: .zip

Change History (5)

sirzooro5 years ago

comment:1 sirzooro5 years ago

  • Keywords needs-testing added

comment:2 coffee2code5 years ago

  • Keywords tested added; needs-testing removed
  • Milestone changed from 2.7.2 to 2.8
  • Summary changed from Missing hooks for custom columns to Missing hook for comments custom column management

+1

Patch applied cleanly against r11001. Though I'm submitting an updated version which is based on a diff performed from the root of trunk (and against the latest rev).

Tested, and works.

To clarify the ticket: in wp-admin/includes/template.php, the function _wp_comment_row() does not specify a default branch in the switch statement to allow a plugin to manage custom columns for comments (i.e., via an add_action('manage_comments_custom_column', ...)).

All other admin row handlers provide such an action/filter to hook.

coffee2code5 years ago

Same as original patch but based on diff from root of trunk and against latest rev ( r11001)

comment:3 ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11007]) Add manage_comments_custom_column hook. Props sirzooro, coffee2code. fixes #9583

Note: See TracTickets for help on using tickets.