WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#9598 closed defect (bug) (fixed)

get_comment_reply_link() Fix for non english slug

Reported by: ramiy Owned by: ryan
Milestone: 2.8 Priority: high
Severity: critical Version: 2.7.1
Component: Permalinks Keywords: permalinks, comments, bugs, urlencode
Focuses: Cc:

Description

File: wp-includes/comment-template.php

Function: get_comment_reply_link

Old: $link = '<a rel="nofollow" href="' . site_url('wp-login.php?redirect_to=' . get_permalink()) . '">' . $login_text . '</a>';

New: $link = '<a rel="nofollow" href="' . site_url('wp-login.php?redirect_to=' . urlencode(get_permalink())) . '">' . $login_text . '</a>';

The "urlencode(get_permalink())" fixes the bug in "redirect_to" link when using non english chrecters in post slug.

Change History (2)

comment:1 ryan5 years ago

  • Milestone changed from 2.7.2 to 2.8

This is fixed in trunk with the use of wp_login_url().

comment:2 ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.