WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#9603 closed enhancement (fixed)

Orphaned code and markup in Recent Comments dashboard widget

Reported by: coffee2code Owned by:
Milestone: 2.9 Priority: low
Severity: minor Version: 2.8
Component: Administration Keywords: has-patch tested
Focuses: Cc:

Description

Attached is a patch in which I've removed a div and its content (markup + code) that were being output for each comment listed in the "Recent Comments" admin dashboard widget. The output is being produced at the end of _wp_dashboard_recent_comments_row() in wp-admin/includes/dashboard.php. The div is hidden, and encapsulates various comment information.

The div and its id do not seem to be referenced in the code at all. The code was added in r9219 and appears to be the hidden bits related to doing in-place editing for the comments via "Quick Edit" links. r9717 removed the "Quick Edit" link, but not any related markup and code.

As the code in question is unnecessary, its removal should get rid of some processing and markup flab.

Attachments (1)

9603.diff​ (963 bytes) - added by coffee2code 5 years ago.
Updated patch to apply cleanly as of r11432

Download all attachments as: .zip

Change History (5)

comment:1 janeforshort — 5 years ago

  • Keywords has-patch needs-testing added
  • Milestone changed from 2.8 to 2.9

Punting due to impending release. Will reconsider in upcoming release cycle.

comment:2 coffee2code — 5 years ago

  • Keywords tested added; needs-testing removed

coffee2code — 5 years ago

Updated patch to apply cleanly as of r11432

comment:3 Denis-de-Bernardy — 5 years ago

still applies clean

comment:4 westi — 5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11708]) Remove comment quickedit data from the dashboard recent comments widget. Fixes #9603 props coffee2code.

Note: See TracTickets for help on using tickets.