get_lastpost* functions only look at post_status

[mtdewvirus]

The get_lastpostdate and get_lastpostmodified functions only use post_status='publish' in the query. According to the name of the function, shouldn't they look for post_type='post'?

Possible solutions:

• Modify current functions to only query posts, create another set of functions get_lastpage* to query pages, and a generic set that uses current logic
• Add a parameter to the current functions to limit by posts or pages.

[ryan]

A post_type option that defaults to 'post' seems good.

[Denis-de-Bernardy]

seems valid except in one case. the two functions only get used in feed-related code, to conditionally serve the feed. the exception is in the next patch.

[Denis-de-Bernardy]

use date() for the copyright notice

[Denis-de-Bernardy]

(the second patch is debatable)

[Denis-de-Bernardy]

On a separate note, those queries are potentially dead slow -- leading to a seq scan of the entire table, from lack of any potential index.

[Denis-de-Bernardy]

actually, ignore that 3rd diff. I'll open a separate ticket that optimizes the beast in its entirety.

[ryan]

(In [11108]) Limit get_lastpost* functions to post_type=post. Props Denis-de-Bernardy. fixes #9636