Error Reporting for Wp-load.php overrides E_DEPRECATED too late

[jacobsantos]

There is a problem with the wp-load.php for the administration where the bootstrap is not setting the E_DEPRECATED and thus you get some notices about deprecation before wp-settings.php overrides the error reporting and stops it any further.

This is a strange error and might have to be with RC2-dev PHP version of PHP5.3.0. However, I am sending it here, just in case it is run-time verses compile-time settings (does not appear to be since moving the E_DEPRECATED outside the if branch, does not remove the warnings.

The strange-ness of the notices is that the notices are in wp-settings.php lines 520+, whereas the error reporting is set in lines 220. There shouldn't be any notices displayed since the error reporting in lines 220 should prevent the notices from showing in 520.

[jacobsantos]

Fix PHP deprecated notices based off of 2.7.1 tag.

[jacobsantos]

Patch should apply to trunk as well. Let me know and I'll create another patch for trunk.

[Denis-de-Bernardy]

Just checking... is this a dup of #8701, or a something specific to 2.7.1 (which will probably never be fixed).

[azaozz]

Yes, it's similar to #8701. However do we need all of these on a production install:

1  	E_ERROR
2 	E_WARNING
4 	E_PARSE
16 	E_CORE_ERROR
32 	E_CORE_WARNING
64 	E_COMPILE_ERROR
128 	E_COMPILE_WARNING
256 	E_USER_ERROR
512 	E_USER_WARNING

Or perhaps we can stick to basic error reporting only:

error_reporting(E_ERROR | E_WARNING | E_PARSE);

Also if we need the long list, why are we "Xor" ^ E_STRICT when we should be tuning it off "And Not" & ~E_STRICT as proposed by westi. That makes the test for PHP 6.x redundant.

[jacobsantos]

It is basically the same as #8701 (why is that still open when it is fixed?) but for wp-load.php.

@azaozz That would work as well. A whitelist is starting to be less work and options than a blacklist.

[jacobsantos]

Replying to azaozz:

Also if we need the long list, why are we "Xor" ^ E_STRICT when we should be tuning it off "And Not" & ~E_STRICT as proposed by westi. That makes the test for PHP 6.x redundant.

In my tests, basically ^ E_STRICT works the same as | ~E_STRICT and same for the others.

[jacobsantos]

Better fix, with just displaying the errors we want.

[jacobsantos]

New error reporting replaces the tests and just displays the errors that we want to see.

[Denis-de-Bernardy]

corrected patch

[Denis-de-Bernardy]

uploaded a corrected patch based on jacob's. See:

​http://fr2.php.net/manual/en/function.error-reporting.php

[jacobsantos]

Meh, Denis's patch will fix the other ticket as well. Please commit, this is actually quite annoying for those on PHP5.3.0rc.

[jacobsantos]

By that, I mean it is annoying to me and maybe one or two others.

[ryan]

(In [11128]) Error reporting fixes. Props Denis-de-Bernardy, jacobsantos. fixes #9639 #8701