WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#9643 closed defect (bug) (fixed)

Category child pretty permalinks 404

Reported by: ev3rywh3re Owned by: ryan
Milestone: 2.8 Priority: high
Severity: critical Version: 2.8
Component: Permalinks Keywords: has-patch
Focuses: Cc:

Description

I recently noticed that category hierarchies seem to be broken. I haven't started digging to find out where and when it broke. The testing site revision number is [11082].

http://mysite.null/category/parent/child/ are causing 404 errors.

http://mysite.null/category/child/ is working instead.

Attachments (1)

9643-query.php.diff (539 bytes) - added by mtekk 5 years ago.
This will get us back to pre #8619 patch working order

Download all attachments as: .zip

Change History (8)

comment:1 mtekk5 years ago

I can reproduce this in r11072, so it was introduced at least a day ago.

comment:2 mtekk5 years ago

Ok, the last revision it worked in was r10955 that means markjaquith broke in in [10956]. Though I don't know how the code added in that revision would cause it to break.

comment:3 follow-up: DD325 years ago

The sanitize_title in that changeset is probably mangling the / in "parent/child" - So the sanitize_title might need to go somewhere more specific..

comment:4 in reply to: ↑ 3 ; follow-up: mtekk5 years ago

Replying to DD32:

The sanitize_title in that changeset is probably mangling the / in "parent/child" - So the sanitize_title might need to go somewhere more specific..

Was just going to post something on those lines.

comment:5 in reply to: ↑ 4 mtekk5 years ago

I should probably also say that sanitize_title is, in fact, removing the / in "parent/child" causing all sorts of problems (can easily observe with some debugging echos).

mtekk5 years ago

This will get us back to pre #8619 patch working order

comment:6 mtekk5 years ago

  • Keywords has-patch added; permalinks categories 404 removed

Should revert the changes made in [10956] and reopen #8619

comment:7 ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11085]) Revert [10956]. fixes #9643 see #8619

Note: See TracTickets for help on using tickets.