initial taxonomies

[arena]

In 2.7 initial taxonomies where created in wp-includes/taxonomy.php

In 2.8 initial taxonomies are created on event 'init' which appears after 'plugins_loaded' event

will propose a patch for this !

[arena]

the 2.8 changes was introduced by #9399 for a translation issue ...

[ryan]

Passing variable to __() will pollute the translation catalog.

Plugins should never do anything before init. Since we accidentally allowed registering taxonomies before init, we can try having registration calls made before init delay registration until init fires, but this can still result in plugin added taxonomies not having properly translated strings.

[Denis-de-Bernardy]

@Ryan: couldn't the load_default_textdomain() call be moved further up? Is there any specific reasons for placing it so low in wp-settings.php?

[arena]

@Ryan, @Denis-de-Bernardy : agree with all your comments,

• about register_taxonomy() : + should initialize $wp_taxonomies if not set

if (!is_array($wp_taxonomies)) $wp_taxonomies = array();

+ maybe adding following test

if (isset($wp_taxonomies[$taxonomy])) return;

• about #9399 patch, + create_initial_taxonomies() should use register_taxonomy(). + add_action( 'init', 'create_initial_taxonomies' ); should have the highest priority to be executed before any other add_action( 'init' ...

• about wp-settings.php + load_default_textdomain() should be moved further up in wp-settings.php (apparently only needs constant WP_LANG_DIR). + maybe create_initial_taxonomies() code should be in wp-settings.php and we would get rid of the "add_action( 'init', 'create_initial_taxonomies' );" .

I am still a bit concerned about existing plugins that are doing things on wordpress "plugins_loaded" event. They could even define some new taxonomies that will be erased by the #9399 patch's "add_action( 'init', 'create_initial_taxonomies' );" .

[Denis-de-Bernardy]

Replying to arena:

I am still a bit concerned about existing plugins that are doing things on wordpress "plugins_loaded" event. They could even define some new taxonomies that will be erased by the #9399 patch's "add_action( 'init', 'create_initial_taxonomies' );" .

I use that hook in a Fixes plugin, that moves plugin hooks around depending on which plugins are loaded. Else there really isn't much use for it. (And even less use for the mu_plugins_loaded hook.)

[arena]

Here attached is a patch 9647_2.diff replacing the previous ones.

• register_taxonomy() : as following tests added

if (!is_array($wp_taxonomies)) $wp_taxonomies = array();

if (isset($wp_taxonomies[$taxonomy])) return;

• create_initial_taxonomies() using register_taxonomy()and add_action( 'init', 'create_initial_taxonomies', 0); with the highest priority.

I think load_default_textdomain() to be moved further up should be delayed to a next release, new ticket !

[arena]

last changes

[ryan]

Looks good. We should still encourage waiting for init to register, but this will preserve old behavior.

[ryan]

(In [11122]) Allow taxonomy registration before init. Props arena. fixes #9647

[Denis-de-Bernardy]

Is this check truly needed?

if (isset($wp_taxonomies[$taxonomy])) 
    return;

I'm itching to open a ticket along the lines of "register_taxonomy() should allow to override a default taxonomy".

[ryan]

We can lose it.

[Denis-de-Bernardy]

Let's drop the check then.

[ryan]

(In [11129]) Allow plugins to override default taxonomies. Props Denis-de-Bernardy. fixes #9647