Make WordPress Core

Opened 16 years ago

Closed 11 years ago

#9679 closed enhancement (maybelater)

Move Plugin/Theme deletion to new WP_Upgrader class

Reported by: dd32's profile DD32 Owned by: dd32's profile DD32
Milestone: Priority: normal
Severity: normal Version: 2.8
Component: Upgrade/Install Keywords: needs-patch
Focuses: Cc:

Description

Expansion off #7875, The plugin/Theme deletions should be also handled by the Upgrader class.

Change History (7)

#1 @DD32
16 years ago

  • Type changed from defect (bug) to enhancement

#2 @hakre
16 years ago

Plugin Deletions do a check upfront to verify that deleting the files of one plugin is interfeering some other plugin (same files used for multiple plugins). also plugin deletion is checking for the plugin uninstall api.

for themes i have no idea.

#3 @DD32
16 years ago

Correct.. Which has absolutely no affect upon this ticket other than to mimic current backend UI.

#4 @hakre
16 years ago

I do not know wether or not the Upgrader Class is there to mimic backend UI or not. Wether it is part of the (then plugin and theme) API or not.

So my concrete question regarding to this ticket is:

1.) Does the upgrader class needs to handle the plugin API, especially the install and uninstall part of it?

#5 @DD32
16 years ago

  • Owner set to DD32

The upgrader class is mearly back-backend, It has a UI class for the UI part of the deal.

Dont worry, I'm not going to remove functionality, Only add or improve the process. (Remember I've written this Upgrader class to remove the old code which i seemed to be the main maintainer of, In the sense that I probably understood it the best, I wasn't happy with the old code.)

I see no reason why the uninstall process cant be handled as well, It'll be left as a separate function, but tied in with the upgrader class. The upgrader class is designed to deal with all the connections and various FS methods which WordPress needs to deal with plugins/themes/custom-objects.

#6 @Denis-de-Bernardy
16 years ago

  • Keywords needs-patch added

#7 @dd32
11 years ago

  • Milestone Future Release deleted
  • Resolution set to maybelater
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.