Filter request: Post comments feed link HTML

[JohnLamansky]

This filter allows rel/style/class/title attributes to be added to the post comments RSS link.

I'd like to use this filter in a plugin I'm developing. Thanks for your consideration.

[JohnLamansky]

I named the filter "post_comments_feed_link_html" because "post_comments_feed_link" is already used to filter the href URL.

[Denis-de-Bernardy]

why is the post_comments_feed_link filter not enough?

[JohnLamansky]

The post_comments_feed_link hook filters the link's URL only.

This proposed post_comments_feed_link_html hook would filter the entire <a> element, allowing rel/style/class/title attributes to be added.

[Denis-de-Bernardy]

maybe the_post_comments_feed_link, to make it consistent with the other hooks?

there also are a couple of other areas where it's called, which might want the filter too.

[JohnLamansky]

Right, it we wanted to be totally consistent, we should rename the existing "the_post_comments_feed_link" filter to "get_post_comments_feed_link" and name this new filter "the_post_comments_feed_link".

Although that would be ideal, such a change could break existing plugins, which is why I suggested that, instead, we could add "_html" to the end of the new hook that would filter the <a> HTML.

[jorbin]

+1
This patch would really help me with a plugin that I am developing.

[Denis-de-Bernardy]

I'd remove the $link_text from the filter's arguments, personally.

[JohnLamansky]

Replying to Denis-de-Bernardy:

I'd remove the $link_text from the filter's arguments, personally.

Good point; the $link_text can be obtained by running strip_tags() on the filter's first argument.

[JohnLamansky]

Removes the $link_text argument, as suggested

[azaozz]

(In [11299]) Post comments feed link HTML filter, props JohnLamansky, fixes #9712