WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#9734 closed defect (bug) (fixed)

wrong filter used in get_post_modified_time()

Reported by: Denis-de-Bernardy Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.8
Component: Template Keywords: has-patch tested commit
Focuses: Cc:

Description

related to #9730

patch attached

Attachments (1)

9734.diff (447 bytes) - added by Denis-de-Bernardy 6 years ago.

Download all attachments as: .zip

Change History (4)

@Denis-de-Bernardy6 years ago

comment:1 @westi6 years ago

This has been like this for a long time.

So changing it breaks backwards compatibility.

However, I don't think that the current hook combination it causes could be used reliably by a plugin so I think it is safe to change.

comment:2 @Denis-de-Bernardy6 years ago

Yeah... it gets applied twice:

DB:~/Sites/wp $ grep -r "'get_the_modified_time'" * | grep -v svn
wp-includes/general-template.php:	return apply_filters('get_the_modified_time', $the_time, $d);
wp-includes/general-template.php:	return apply_filters('get_the_modified_time', $time, $d, $gmt);

comment:3 @ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11347]) Use get_post_modified_time filter in get_post_modified_time(). Props Denis-de-Bernardy. fixes #9734

Note: See TracTickets for help on using tickets.