dynamic_sidebar() should not save widgets on theme preview

[Denis-de-Bernardy]

when looking a theme that adds widgets and sidebars, dynamic_sidebar() calls currently save the sidebars_widgets option.

this should not happen.

[Denis-de-Bernardy]

the test could also be a straight false, or !is_admin()...

[Denis-de-Bernardy]

mm, that is_preview() actually is for post previews. so the call is erroneous.

[Denis-de-Bernardy]

better patch

[azaozz]

Replying to Denis-de-Bernardy:

when looking a theme that adds widgets and sidebars, dynamic_sidebar() calls currently save the sidebars_widgets option.

The option is updated only when $sidebars_widgets['array_version'] = 3 is not set and is_admin() is true. This is a test if the data in the array is in old format which only happens when upgrading WordPress from 2.3 (I think).

[Denis-de-Bernardy]

Actually, it's:

wp_get_sidebars_widgets($update = true)

And the update occurs if $update is true and is_admin(), rather than if the array_version is not 3 and is_admin(). But agreed, it's a rather minor.

[azaozz]

There's a switch() in wp_get_sidebars_widgets() that doesn't match when the array_version is set to 3. Can add this but don't think it will have any impact, as you say it's minor.