WordPress.org

Make WordPress Core

Opened 6 years ago

Last modified 6 days ago

#9777 new enhancement

Usability : add delete button to edit-tags.php

Reported by: ramiy Owned by:
Milestone: Future Release Priority: normal
Severity: minor Version: 2.7.1
Component: Taxonomy Keywords: has-patch 4.2-early
Focuses: ui, administration Cc:

Description

Add "delete" button to "edit category" menu so i can delete the category and not only edit it. this is a very useful feature that is missing in this menu.

LOCATION:

Admin -> Posts -> Categories -> Edit Category

URL:

http://www.site.org/wp-admin/categories.php?action=edit&cat_ID=302

Attachments (15)

9777.diff (168.0 KB) - added by cklosows 3 years ago.
Creates Red "Delete" link on the edit page of a category or tag.
9777.2.diff (2.5 KB) - added by cklosows 3 years ago.
Removing modifications to minified CSS
9777.2.2.diff (1.5 KB) - added by cklosows 5 months ago.
Refreshing the original patch in a more re-usable way.
9777.3.diff (1.9 KB) - added by cklosows 5 months ago.
Properly handling the redirections after deletes by removing the query args of deleted term ID as well as the action, after the wp_delete_term
9777.4.diff (2.0 KB) - added by cklosows 5 months ago.
Adding JS to prompt on delete, as well as hiding the delete on the default category.
term-delete.png (8.6 KB) - added by ocean90 5 months ago.
9777.5.diff (2.1 KB) - added by bradt 4 months ago.
Screen Shot 2014-11-14 at 2.07.52 PM.png (41.2 KB) - added by bradt 4 months ago.
9777.6.diff (2.9 KB) - added by bradt 3 months ago.
Replaced onclick attribute with proper JS.
9777.7.diff (3.0 KB) - added by DrewAPicture 5 weeks ago.
refresh
Screen Shot 2015-03-11 at 11.26.30 AM.png (190.5 KB) - added by ryan 2 weeks ago.
9777.7.diff on Macnchrome
IMG_0761.PNG (163.4 KB) - added by ryan 2 weeks ago.
9777.7.diff on iPhone 6+.
9777.8.diff (3.7 KB) - added by bradt 7 days ago.
Improved the UI.
Screen Shot 2015-03-20 at 5.04.09 PM.png (311.5 KB) - added by bradt 7 days ago.
Screen Shot 2015-03-20 at 5.13.15 PM.png (85.0 KB) - added by bradt 7 days ago.

Download all attachments as: .zip

Change History (55)

comment:1 in reply to: ↑ description @ramiy6 years ago

  • Milestone changed from 2.9 to 2.8

Replying to ramiy:

Add "delete" button to "edit category" menu so i can delete the category and not only edit it. this is a very useful feature that is missing in this menu.

LOCATION:

Admin -> Posts -> Categories -> Edit Category

URL:

http://www.site.org/wp-admin/categories.php?action=edit&cat_ID=302

comment:2 @ryan6 years ago

  • Severity changed from major to minor

comment:3 @Denis-de-Bernardy6 years ago

  • Milestone changed from 2.8 to Future Release

punting pending patch

comment:4 @ramiy5 years ago

This enhancement is needed at "tag edit menu" too.

comment:5 @solarissmoke4 years ago

  • Keywords dev-feedback added; Admin Categories Edit delete usability removed

There are quite a lot of places where the "edit" screen doesn't let you delete:

  • Admin -> Users
  • Admin -> Media
  • Admin -> Links
  • Admin -> Links -> Link Categories

plus those mentioned above.

Do they all want changing?

comment:6 @ramiy4 years ago

  • Cc ramiy added

Replying to solarissmoke:

For me, as a user, it would be easier to delete category/tag/taxonomy/media/link/user/post/page from the "edit" screen. The "edit" screen shows me all the infoamation about this tag/cat/post and i can decide if i need it or not.

comment:7 @scribu4 years ago

Huh, never noticed that until now.

comment:8 @jorbin4 years ago

  • Keywords ux-feedback added

comment:9 follow-up: @scribu4 years ago

  • Keywords ui-feedback added; dev-feedback ux-feedback removed

I think it's safe to say that this is a good idea, for all screens mentioned by solarissmoke.

Just need to decide how it should look like.

I'm thinking of a red link, next to the Update button.

comment:10 in reply to: ↑ 9 @ramiy4 years ago

Replying to scribu:

I think it's safe to say that this is a good idea.

thank you scribu. hope to see this in 3.2.

comment:11 @SergeyBiryukov4 years ago

  • Keywords needs-patch added

comment:12 follow-up: @SergeyBiryukov4 years ago

  • Keywords needs-patch removed

Actually, all of the mentioned list screens already have the Delete links in 3.2:

  • Posts → Categories
  • Posts → Tags
  • Media → Library
  • Links → All Links
  • Links → Link Categories
  • Users → All Users

Perhaps a separate link on edit screens is no longer needed?

comment:13 in reply to: ↑ 12 @ramiy4 years ago

Sergey, we are no talking about the "Quick Edit" on

  • Posts → Categories
  • /wp-admin/edit-tags.php?taxonomy=category

We are talking about the "Category Edit" screen.

  • Posts → Categories → SomeCategory
  • /wp-admin/edit-tags.php?action=edit&taxonomy=category&tag_ID=11&post_type=post

comment:14 @SergeyBiryukov4 years ago

Yeah, I see it. I assumed it was only needed due to lack of the Delete links in Quick Edit in 3.1. Now that we have them, is it still necessary on Edit screens?

comment:15 @ramiy4 years ago

Yes, it's needed! i dont use the "Quick Edit" and when i want to delete some cat/tag/ct i go to it's edit page to see all the parameters before i delete it. And the current edit page has no "Delete" button and it's frustrating.

comment:16 @SergeyBiryukov4 years ago

  • Keywords needs-patch added

@cklosows3 years ago

Creates Red "Delete" link on the edit page of a category or tag.

comment:17 @cklosows3 years ago

  • Cc cklosowski@… added

comment:18 @cklosows3 years ago

  • Keywords has-patch added

comment:19 @cklosows3 years ago

  • Keywords needs-patch removed

comment:20 follow-up: @SergeyBiryukov3 years ago

No need to patch minified .css and .js, they'll quickly become stale.

With #19592, they are now updated automatically when the .dev versions are committed.

comment:21 in reply to: ↑ 20 @cklosows3 years ago

Replying to SergeyBiryukov:

No need to patch minified .css and .js, they'll quickly become stale.

With #19592, they are now updated automatically when the .dev versions are committed.

Sounds good, I'll fix that up tonight and recreate my patch.

@cklosows3 years ago

Removing modifications to minified CSS

comment:22 @ramiy20 months ago

  • Summary changed from Usability : add delete button to "edit category" menu to Usability : add delete button to "edit category" screen

comment:23 @helen14 months ago

  • Focuses ui added
  • Keywords needs-refresh added; ui-feedback removed

comment:24 @nacin14 months ago

  • Component changed from Administration to Taxonomy
  • Focuses administration added

@cklosows5 months ago

Refreshing the original patch in a more re-usable way.

comment:25 @cklosows5 months ago

  • Keywords needs-refresh removed

comment:26 @cklosows5 months ago

Actually there's a bug in the patch, the URL attempts to get back to the deleted term. Will fix that and resubmit.

@cklosows5 months ago

Properly handling the redirections after deletes by removing the query args of deleted term ID as well as the action, after the wp_delete_term

comment:27 @cklosows5 months ago

  • Summary changed from Usability : add delete button to "edit category" screen to Usability : add delete button to edit-tags.php

@cklosows5 months ago

Adding JS to prompt on delete, as well as hiding the delete on the default category.

comment:28 @johnbillion5 months ago

  • Milestone changed from Future Release to 4.1

comment:29 @slackbot5 months ago

This ticket was mentioned in Slack in #core by drew. View the logs.

@ocean905 months ago

comment:30 @ocean905 months ago

The delete links needs a better place, see term-delete.png. The link shouldn't be that close to the update button.

Last edited 5 months ago by ocean90 (previous) (diff)

@bradt4 months ago

comment:31 @bradt4 months ago

  • Tweaked the position so it's not so snug to the button
  • Removed the underline to be consistent with other action links in the dashboard

Tested in latest FF, Chrome, Safari on OS X.

comment:32 @helen4 months ago

  • Keywords 4.2-early added
  • Milestone changed from 4.1 to Future Release

We're in beta now - let's grab this in 4.2. If another committer really wants to own this, it can probably be rescued for 4.1. I don't really like adding an onclick attribute, though.

comment:33 @bradt4 months ago

I don't really like adding an onclick attribute, though.

Agreed.

In fact, I hate prompts. Undo links are a much better experience.

Ideally we'd show an undo link in the delete notice instead of a prompting before delete.

comment:34 @cklosows4 months ago

Then we should look at the action links on the taxonomy list page. This mimics the exact same mechinisim and prompt for deletion.

@bradt3 months ago

Replaced onclick attribute with proper JS.

comment:35 @iseulde2 months ago

  • Milestone changed from Future Release to 4.2

has-patch 4.2-early so moving to 4.2.

comment:36 @slackbot6 weeks ago

This ticket was mentioned in Slack in #core by drew. View the logs.

@DrewAPicture5 weeks ago

refresh

comment:37 @slackbot2 weeks ago

This ticket was mentioned in Slack in #core by drew. View the logs.

@ryan2 weeks ago

9777.7.diff on Macnchrome

@ryan2 weeks ago

9777.7.diff on iPhone 6+.

comment:38 @ryan2 weeks ago

  • Milestone changed from 4.2 to Future Release

Punting enhancements from 4.2 per the bug scrub. I attached desktop and mobile screenshots to help move the ticket along when 4.3 opens.

@bradt7 days ago

Improved the UI.

comment:39 @bradt6 days ago

Submitted a new patch with an updated UI in line with what @johnbillion and @DrewAPicture discussed on Slack.

comment:40 @ramiy6 days ago

We can also make it two columns screen, like the post edit screen.

On the right sidebar, show the "Publish" metabox with action buttons (Update & Delete) and other term info like the taxonomy name and the post count.

Note: See TracTickets for help on using tickets.