Add "delete" button to term pages

[ramiy]

Add "delete" button to "edit category" menu so i can delete the category and not only edit it. this is a very useful feature that is missing in this menu.

LOCATION:

Admin -> Posts -> Categories -> Edit Category

URL:

​http://www.site.org/wp-admin/categories.php?action=edit&cat_ID=302

[ramiy]

Replying to ramiy:

Add "delete" button to "edit category" menu so i can delete the category and not only edit it. this is a very useful feature that is missing in this menu.

LOCATION:

Admin -> Posts -> Categories -> Edit Category

URL:

​http://www.site.org/wp-admin/categories.php?action=edit&cat_ID=302

[Denis-de-Bernardy]

punting pending patch

[ramiy]

This enhancement is needed at "tag edit menu" too.

• Admin -> Posts -> Tags -> ​Edit Tag
• Admin -> Posts -> Categories -> ​Edit Category

[solarissmoke]

There are quite a lot of places where the "edit" screen doesn't let you delete:

• Admin -> Users
• Admin -> Media
• Admin -> Links
• Admin -> Links -> Link Categories

plus those mentioned above.

Do they all want changing?

[ramiy]

Replying to solarissmoke:

For me, as a user, it would be easier to delete category/tag/taxonomy/media/link/user/post/page from the "edit" screen. The "edit" screen shows me all the infoamation about this tag/cat/post and i can decide if i need it or not.

[scribu]

Huh, never noticed that until now.

[scribu]

I think it's safe to say that this is a good idea, for all screens mentioned by solarissmoke.

Just need to decide how it should look like.

I'm thinking of a red link, next to the Update button.

[ramiy]

Replying to scribu:

I think it's safe to say that this is a good idea.

thank you scribu. hope to see this in 3.2.

[SergeyBiryukov]

Actually, all of the mentioned list screens already have the Delete links in 3.2:

• Posts → Categories
• Posts → Tags
• Media → Library
• Links → All Links
• Links → Link Categories
• Users → All Users

Perhaps a separate link on edit screens is no longer needed?

[ramiy]

Sergey, we are no talking about the "Quick Edit" on

• Posts → Categories
• /wp-admin/edit-tags.php?taxonomy=category

We are talking about the "Category Edit" screen.

• Posts → Categories → SomeCategory
• /wp-admin/edit-tags.php?action=edit&taxonomy=category&tag_ID=11&post_type=post

[SergeyBiryukov]

Yeah, I see it. I assumed it was only needed due to lack of the Delete links in Quick Edit in 3.1. Now that we have them, is it still necessary on Edit screens?

[ramiy]

Yes, it's needed! i dont use the "Quick Edit" and when i want to delete some cat/tag/ct i go to it's edit page to see all the parameters before i delete it. And the current edit page has no "Delete" button and it's frustrating.

[cklosows]

Creates Red "Delete" link on the edit page of a category or tag.

[SergeyBiryukov]

No need to patch minified .css and .js, they'll quickly become stale.

With #19592, they are now updated automatically when the .dev versions are committed.

[cklosows]

Replying to SergeyBiryukov:

No need to patch minified .css and .js, they'll quickly become stale.

With #19592, they are now updated automatically when the .dev versions are committed.

Sounds good, I'll fix that up tonight and recreate my patch.

[cklosows]

Removing modifications to minified CSS

[cklosows]

Refreshing the original patch in a more re-usable way.

[cklosows]

Actually there's a bug in the patch, the URL attempts to get back to the deleted term. Will fix that and resubmit.

[cklosows]

Properly handling the redirections after deletes by removing the query args of deleted term ID as well as the action, after the wp_delete_term

[cklosows]

Adding JS to prompt on delete, as well as hiding the delete on the default category.

[ocean90]

The delete links needs a better place, see term-delete.png​. The link shouldn't be that close to the update button.

[bradt]

• Tweaked the position so it's not so snug to the button
• Removed the underline to be consistent with other action links in the dashboard

Tested in latest FF, Chrome, Safari on OS X.

[helen]

We're in beta now - let's grab this in 4.2. If another committer really wants to own this, it can probably be rescued for 4.1. I don't really like adding an onclick attribute, though.

[bradt]

I don't really like adding an onclick attribute, though.

Agreed.

In fact, I hate prompts. Undo links are a much better experience.

Ideally we'd show an undo link in the delete notice instead of a prompting before delete.

[cklosows]

Then we should look at the action links on the taxonomy list page. This mimics the exact same mechinisim and prompt for deletion.

[bradt]

Replaced onclick attribute with proper JS.

[iseulde]

has-patch 4.2-early so moving to 4.2.

[DrewAPicture]

refresh

[ryan]

9777.7.diff on Macnchrome

[ryan]

9777.7.diff on iPhone 6+.

[ryan]

Punting enhancements from 4.2 per the bug scrub. I attached desktop and mobile screenshots to help move the ticket along when 4.3 opens.

[bradt]

Improved the UI.

[bradt]

Submitted a new patch with an updated UI in line with what @johnbillion and @DrewAPicture discussed on ​Slack.

[ramiy]

We can also make it two columns screen, like the post edit screen.

On the right sidebar, show the "Publish" metabox with action buttons (Update & Delete) and other term info like the taxonomy name and the post count.

[bradt]

@ramily IMO it's not worth going to a two column layout.

Just checked the patch and it still applies cleanly.

[ramiy]

Two column layout for taxonomy terms - maybe in wordpress 5.2
;-)

[obenland]

No traction in 4.3.

[bradt]

Just re-tested against trunk, patch still applies cleanly.

[tzon]

9777.7 screenshot looks better than 9777.8 screenshot with delete button to the right of the Update button.
The delete button from 9777.7 worked correctly.

[bradt]

Just re-tested against trunk, patch still applies cleanly.

[cklosows]

Patch refresh

[cklosows]

Retested, and patch needed a refresh. Removed some CSS that was no longer needed.

[cklosows]

Add inline comment to make it clear why the remove_query_arg is necessary.

[johnbillion]

Thanks for the patch, @cklosows!

This button needs to be wrapped in a current_user_can( 'delete_term', $tag_ID ) check. This will also negate the need for the default category check, which is now handled inside the cap check since #35614.

[cklosows]

Replace the default category check to using the capability check as it's implicitly checked.

[ramiy]

Related: #36574 (Redesign term pages)

The "delete" button can be on the sidebar, inside the "Publish" meta box.

[MatheusGimenez]

Fix JS confirm box to prevent delete by mistake

[MatheusGimenez]

Remove var_dump() (sorry, rs)

[arshidkv12]

js file wp_enqueue_script('admin-tags'); not working on my system. I think, it is not registered.

[maguiar]

Tested latest patch, working as expected:

[adamsilverstein]

In 40655:

Taxonomy: Add a "delete" button on term edit page.

Add a 'delete' link next to the update button on the term edit screen so you can delete a term while you are reviewing it's details.

Props cklosows, bradt, ocean90, johnbillion, DrewAPicture, ryan, MatheusGimenez, maguiar.
Fixes #9777.

[Chouby]

40655 introduced an error in the html markup output. I propose a patch in 9777.11.diff

[rachelbaker]

In 40668:

Taxonomy: Remove extraneous ' included in Term delete markup.

Unmatched single quotation mark after the delete link href was introduced in r40655.

Props Chouby.
Fixes #9777.

[adamsilverstein]

Thanks for catching and fixing that @Chouby.

[afercia]

In 44621:

Taxonomy: Remove extra padding around buttons on term edit page.

Props monikarao, mukesh27, chetan200891.
See #9777.
Fixes #45183.