Make WordPress Core

Opened 15 years ago

Closed 15 years ago

Last modified 9 years ago

#9779 closed enhancement (wontfix)

Inconsistency between WP_PLUGIN_DIR and plugin_dir_path(), etc.

Reported by: denis-de-bernardy's profile Denis-de-Bernardy Owned by: markjaquith's profile markjaquith
Milestone: Priority: high
Severity: minor Version: 2.8
Component: Plugins Keywords: has-patch tested commit dev-feedback
Focuses: Cc:

Description

It's rather minor, if it this is to get fixed, it's now or never.

The various path and url constants in WP don't add a trailing slash (except ABSPATH), and neither do the various content_url() et al functions. But plugin_dir_path() and plugin_dir_url() do.

Shouldn't it be consistent across the board?

Attachments (1)

9779.diff (1.1 KB) - added by Denis-de-Bernardy 15 years ago.

Download all attachments as: .zip

Change History (9)

#1 @Denis-de-Bernardy
15 years ago

  • Keywords has-patch dev-feedback added

#2 @Denis-de-Bernardy
15 years ago

  • Summary changed from Inconsistency between WP_PLUGIN_DIR and plugin_dir_path() to Inconsistency between WP_PLUGIN_DIR and plugin_dir_path(), etc.

#3 @Denis-de-Bernardy
15 years ago

  • Component changed from General to Plugins
  • Owner anonymous deleted

#4 @Denis-de-Bernardy
15 years ago

  • Keywords tested commit added
  • Priority changed from low to high

#5 @westi
15 years ago

  • Owner set to markjaquith

Leaving this for Mark.

I can see that they are inconsistent but they are well documented and the slashes make them easier to use so I am on the WONTFIX side of the fence.

#6 @Denis-de-Bernardy
15 years ago

either way works for me, since it's documented. I merely meant to highlight the inconsistency with the other *_url() functions, which are not trailingslashed. once 2.8 is released, it'll be to late.

#7 @westi
15 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

Talked to Mark and he agrees WONTFIX as this way they are easier to use.

#8 @DrewAPicture
9 years ago

  • Milestone 2.8 deleted
Note: See TracTickets for help on using tickets.