WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#9792 closed defect (bug) (fixed)

inconsistent name spaces hooks in rss/atom feeds

Reported by: Denis-de-Bernardy Owned by: westi
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.8
Component: Feeds Keywords: has-patch tested commit
Focuses: Cc:

Description

  • atom: ns_atom
  • atom/comments: ns_atom
  • rss2: ns_rss2
  • rss2/comments: ns_comments_rss2 since r11279

backward compat probably prevents to use ns_comments_atom.

either way, things should be consistent.

Attachments (2)

9792.diff (490 bytes) - added by Denis-de-Bernardy 5 years ago.
9792-whale.patch (994 bytes) - added by peaceablewhale 5 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Denis-de-Bernardy5 years ago

  • Owner set to westi

Denis-de-Bernardy5 years ago

comment:2 peaceablewhale5 years ago

"atom_ns" and "rss2_ns" are general namespaces that both the general and comments feed can share while "rss2_comments_ns" may be used for adding namespaces to the comments feed only. I suggest adding "rss2_ns" to feed-rss2-comments.php and "atom_comments_ns" to feed-atom-comments.php.

peaceablewhale5 years ago

comment:3 Denis-de-Bernardy5 years ago

  • Keywords has-patch tested commit added

+1. that way we keep backwards compat and we don't introduce inconsistencies.

comment:4 ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11303]) Feed namespace hooks. Props Denis-de-Bernardy, peaceablewhale. fixes #9792

Note: See TracTickets for help on using tickets.