a better unhtmlentities()

[Denis-de-Bernardy]

TinyMCE's Googlespell plugin contains a version of unhtmlentities that looks a little better than the one we currently use in the WP, RSS and Blogware importers.

[Denis-de-Bernardy]

the e regex modifier would probably need to be removed before this gets committed. some testing is in order before it's added either way.

[Denis-de-Bernardy]

per bforchhammer's suggestion, see #9798

[Denis-de-Bernardy]

importer works fine with patch applied.

[Denis-de-Bernardy]

re-assigning this to early 2.9, however, in case it has unexpected side effects.

[hakre]

+1 for having the e modifier out there.

strtr() does not look as a fitting function to, this will lead to data-loss. str_replace should do the job instead.

[hakre]

Replying to hakre:

strtr() does not look as a fitting function to, this will lead to data-loss. str_replace should do the job instead.

ignore that comment please, it's a mistake of mine.

[hakre]

reviewed and tested the patch. works.

while we're at it, there was code duplication between the patched classes so that my patch adds a base_importer class which can be inherited to compact the code.

[dd32]

Now that we require PHP 4.3, Theres no need at all for those functions.

Suggest closing this ticket in favour of:

#11636: enhancement: Replace unhtmlentities() methods in three importers

[nacin]

Patch in #11636.