make better use of stubs when verbose rules should apply

[Denis-de-Bernardy]

Related to:

​http://core.trac.wordpress.org/ticket/6603#comment:27

Problem fixed is:

posts show up as www.apexprd.org/page/2 and not /news-and-events/page/2 as it should.

with permalinks set to /something/$postname%/

we arguably don't necessarily need verbose rules here, since there is a stub.

[Denis-de-Bernardy]

see also #9825

[anonymized_6443559]

In wp-includes/rewrite.php on line 1984.

change code to if ( preg_match("#\A/%(?:postname|category|tag|author)%#", $this->permalink_structure) )

Works on my test. It appears the current regular expression returns looks at the first wildcard and if it is postname, category, tag, or author returns true, forcing verbose page rules. However per discussion on wp-hackers mailing list verbose page rules need not apply in all cases where one of those items is the first wildcard, if preceeded by a static string, such as /blog/%pagename%. My new regular expression specifically looks at the first element in the path and if it is one of those 4 wildcards returns true, otherwise if its some other wildcard or a string like /blog/... returns false ensuring verbose page rules are set only when absolutley necessary.

Sorry I was unable to provide a .diff for this, I could not get the current code to checkout from subversion, some error I have been unable to resolve, so since its a minor fix figured i'd just include it as a comment here to be included in next release hopefully.

[blt4]

Attached is a patch that should fix this.

Current code makes the verbose rules judgement based on the first structure tag. ​This post suggests you should be able to use a static string in front of a string structure tag to prevent verbose rules.

For example, the following permalink custom structure should not trigger verbose rules, but does in WP 3.0.1:

/view/%pagenum%

[scribu]

(In [15987]) Don't trigger verbose page rules if permalink begins with fixed string. Fixes #9824

[nacin]

(In [15988]) Bool cast preg_match. see #9824.

[nacin]

(In [15989]) Bool cast preg_match, in readable form. see #9824.

[nacin]

This resulted in #16041. Suggest revert and punt.

[SergeyBiryukov]

I guess we need to exclude the standard prefixes, e.g. /index.php without mod_rewrite and /blog on Multisite. This also fixes the issue in #16041. Uploaded the patch.

[SergeyBiryukov]

Added specific check for Multisite.

[ryan]

(In [17226]) Revert [15987] [15988] [15989]. Props SergeyBiryukov. see #9824 fixes #16041

[nacin]

Additional issues: #16136.

[scribu]

I think we should take another swing at this.

[SergeyBiryukov]

Is there something not covered by 9824.3.patch​?

[SergeyBiryukov]

Refreshed for 3.3.

[nacin]

Looks like it. It doesn't cause any issue in either #16136 or #16041?

The thing I see is that /blog can be changed via a manual edit to the permalink_structure. If we're on the main site of a subdirectory multisite, perhaps we should pop off the first segment? Might need wpmuguru to explain what people may change that to.

[SergeyBiryukov]

Removed hardcoded /index.php and /blog

[SergeyBiryukov]

Replying to nacin:

It doesn't cause any issue in either #16136 or #16041?

Nope.

The thing I see is that /blog can be changed via a manual edit to the permalink_structure. сIf we're on the main site of a subdirectory multisite, perhaps we should pop off the first segment?

Done in 9824.5.patch​. Perhaps instead of a hardcoded value, it should be a variable in WP_Rewrite, like $wp_rewrite->index?

[nacin]

This ticket is mitigated by the fix in #16687, but it'd still be nice to get this in.