WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#9832 closed defect (bug) (fixed)

Plugin Installer; JS tab swtching not working

Reported by: dd32 Owned by: DD32
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.8
Component: Upgrade/Install Keywords: has-patch
Focuses: Cc:

Description

The iframe helper used by the Plugin Information dialogue doesnt fire the admin footer hooks, As a result, If compressed JS is in use, they're not loaded.

This has the effect of preventing the JS-changing of the tabs from working.

See attached patch.

Attachments (1)

9832.diff (905 bytes) - added by dd32 5 years ago.

Download all attachments as: .zip

Change History (4)

dd325 years ago

comment:1 azaozz5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11366]) Add footer actions to iframe footer, props DD32, fixes #9832

comment:2 azaozz5 years ago

Usually $hook_suffix is not set in the iframe. Can probably be replaced by a generic string so plugins can enqueue scripts only there, but preferably scripts and styles should be enqueued just before calling iframe_header().

comment:3 dd325 years ago

thanks for cleaning up the patch azaozz :)

Note: See TracTickets for help on using tickets.