WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#9834 closed defect (bug) (fixed)

Missing HTML break in user-new.php (after 2nd password field)

Reported by: demetris Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.8
Component: UI Keywords: reporter-feedback
Focuses: Cc:

Description

See attached patch.

Attachments (2)

t9834-user-new-break-missing.diff (653 bytes) - added by demetris 5 years ago.
Missing HTML break after 2nd password field in user-new.php
t9834-issue-screenshot-fx36.png (71.1 KB) - added by demetris 5 years ago.
A screenshot of the issue (in Fx 3.6)

Download all attachments as: .zip

Change History (9)

demetris5 years ago

Missing HTML break after 2nd password field in user-new.php

comment:1 sivel5 years ago

  • Cc matt@… added
  • Keywords dev-feedback added
  • Priority changed from normal to lowest
  • Severity changed from normal to trivial

Can you explain why this is needed. I cannot see any reason that this br should need to be added.

demetris5 years ago

A screenshot of the issue (in Fx 3.6)

comment:2 demetris5 years ago

  • Priority changed from lowest to normal
  • Severity changed from trivial to normal

I attached a screenshot.

Does this display OK in other people’s systems?

comment:3 azaozz5 years ago

  • Keywords reporter-feedback added; has-patch tested dev-feedback removed

Don't think a break is needed before the <div>, there are no floats there. Are you using the default styles? Also testing in FF 3.5 would be better as 3.6 is pre-alpha I think.

comment:4 demetris5 years ago

Heh! None of the 3 browsers I tested with was in a stable version, but, since they were 3 different engines, I thought it would be a general issue. Also, the style on the screenshot is not the default (I have remove border-radius from everything) but I verified the issue with the default style (and with all plugins deactivated) before opening the ticket.

Now I’ve done some more testing. Here are the results...

THE PROBLEM DOES NOT APPEAR IN:

  • Epiphany 2.26.1
  • Firefox 3.0.10
  • IE 6
  • IE 7

THE PROBLEM APPEARS IN:

  • Chrome 1.0.154.65
  • Chrome 2.0.180.0 Developer Preview
  • Firefox 3.1 Beta 3
  • Firefox (Minefield) 3.6 Alpha 1 Pre (current nightly)
  • IE 8
  • Konqueror 3.5
  • Opera 9.64
  • Opera 10.00 Alpha Build 1497
  • Safari 3.2.1
  • Safari 4.0

comment:5 azaozz5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11369]) Add HTML break in user-new.php, props demetris, fixes #9834

comment:6 azaozz5 years ago

You're right, that <div> is floated. Firebug bailed out on me.

comment:7 demetris5 years ago

I’m just happy I’m not a web designer. :-D

Note: See TracTickets for help on using tickets.