WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#9836 closed enhancement (fixed)

WP Upgrader small improvements

Reported by: Simek Owned by: dd32
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.8
Component: Upgrade/Install Keywords: has-patch needs-testing
Focuses: Cc:

Description

  1. Show "Return to Plugins page" link on the update page when plugin is at the latest version.


  1. Fix to show "The theme is at the latest version." message and page header instead of blank page on the update page when theme is at the latest version. (I don't know why "$this->skin->after();" not working here.)

Attachments (2)

9836.patch (888 bytes) - added by Simek 6 years ago.
9936.diff (4.3 KB) - added by dd32 6 years ago.

Download all attachments as: .zip

Change History (6)

@Simek6 years ago

comment:1 @Denis-de-Bernardy6 years ago

  • Keywords needs-testing added

I'll give this one a shot when I'll do my plugin that related to the upgrader classes.

comment:2 @dd326 years ago

  • Owner changed from DD32 to dd32
  • Status changed from new to reviewing

@dd326 years ago

comment:3 @dd326 years ago

  • Status changed from reviewing to accepted

attachment 9936.diff added

  • Based off Simek's patch
  • Fixes the ::after() calling
    • Need to set the result to prevent notices being thrown
    • Need to wrap some of the theme's ::after() in a If with a few conditionals (Which looks crazy, but it makes sense) since otherwise errors would be thrown (When the files are not there its expecting)

comment:4 @azaozz6 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [11525]) WP Upgrader improvements, props DD32, fixes #9836

Note: See TracTickets for help on using tickets.