Fallback function htmlspecialchars_decode fails on Systems prior PHP 5.1.0

[unknown33]

The fallback function htmlspecialchars_decode uses wrong variables.

This bug happens in compat.php on systems using PHP prior 5.1.0.

The problem is the check:

if ( !is_scalar( $string ) ) {
trigger_error( 'htmlspecialchars_decode() expects parameter 1 to be string, ' . gettype( $string ) . ' given', E_USER_WARNING );

return;

}

this needs to be changed to:

if ( !is_scalar( $str ) ) {
trigger_error( 'htmlspecialchars_decode() expects parameter 1 to be string, ' . gettype( $str ) . ' given', E_USER_WARNING );

return;

}

Means the variable $str is not used in the check.

Cheers Dirk

[ryan]

See #9090 and #9475