WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#9897 closed defect (bug) (fixed)

Use Stylesheet instead of Template to key theme data when doing theme update check

Reported by: josephscott Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.8
Component: General Keywords: has-patch
Focuses: Cc:

Description

When sending theme data during the theme update check using the 'Template' name to key the data is causing problems for parent/child themes. Because they both have the same 'Template' value the child would over write the parent data, basically causing the parent theme to be skipped when doing the theme update check.

So instead of Template we should key the data from the Stylesheet value, which isn't shared in parent/child themes.

Attachments (1)

wp-includes--update.php.diff (793 bytes) - added by josephscott 6 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 @ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11424]) Use Stylesheet instead of Template to key theme data when doing theme update check. Props josephscott. fixes #9897

comment:2 @Denis-de-Bernardy6 years ago

Just curious... in addition to this, shouldn't we enforce that the parent theme is up to date before allowing the child theme to update? Or better yet, update both at the time?

Note: See TracTickets for help on using tickets.