WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#9920 closed defect (bug) (fixed)

Getting a blank darkbox in theme installer

Reported by: pianoguy91 Owned by: dd32
Milestone: 2.8 Priority: normal
Severity: major Version: 2.8
Component: Upgrade/Install Keywords: has-patch commit
Focuses: Cc:

Description

Every time I click on the theme image to preview it, I get a blank darkbox with no preview. When I click anywhere else on the page it returns to the normal page. Clicking on the Preview link works just fine, however.

Since this is a usability issue, this should have a higher priority.

Attachments (1)

9920.diff (598 bytes) - added by dd32 6 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 @Denis-de-Bernardy6 years ago

  • Keywords reporter-feedback added

Can you confirm this in 2.8 beta-2? A bug was fixed in it, namely related to themes with dashes in them not getting previewed properly.

If it's still happening, please add more details (how to reproduce).

comment:2 @Denis-de-Bernardy6 years ago

  • Component changed from General to Upgrade/Install
  • Owner set to dd32

comment:3 @dd326 years ago

  • Keywords needs-patch added; reporter-feedback removed
  • Priority changed from high to normal
  • Status changed from new to accepted
  • Version set to 2.8

I see the problem, I'll get a patch up in a moment.

@dd326 years ago

comment:4 @dd326 years ago

  • Keywords has-patch commit added; needs-patch removed

ended up being simpler than i thought.

A short tag <? instead of a full tag.

I did a scan of the rest of WordPress, Its the only one currently there.

comment:5 @ryan6 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [11459]) Don't use short tag. Props DD32. fixes #9920

Note: See TracTickets for help on using tickets.