Missing preg_quote parameters

[Denis-de-Bernardy]

Found this while investigating a bug in a plugin.

when the second argument is null, preg_quote() assumes the regexp is wrapped around {}. But WP occasionally uses it with / wrappers.

[Denis-de-Bernardy]

I ignored snoopy, presuming it was obsolete anyway.

Patch needs some testing.

[Denis-de-Bernardy]

still applies clean

[Denis-de-Bernardy]

closed #10144 as dup

[jdub]

I'd really urge you to consider this patch as a bugfix for 2.8.1 (I reported the dupe). Thanks.

[ryan]

(In [11634]) Pass delimiter to preg_quote(). Props Denis-de-Bernardy. see #9955

[ryan]

(In [11635]) Pass delimiter to preg_quote(). Props Denis-de-Bernardy. see #9955

[ryan]

I went ahead and committed the simple cases for 2.8.1. I want to test the shortcodes.php one a bit more.

[Denis-de-Bernardy]

cool. the one for shortcodes is unneeded if we change add_shortcode() to use:

	if ( is_callable($func) )
		$shortcode_tags[$tag] = $func;

to something like:

	$tag = sanitize_title($tag);
	if ( is_callable($func) )
		$shortcode_tags[$tag] = $func;

[azaozz]

Also the last two in xmlrpc.php L:3303 and L:3325 seem unneeded as preg_quote() escapes | (pipe) by default ​http://us2.php.net/manual/en/function.preg-quote.php

[Denis-de-Bernardy]

good point. in this case, the one for shortcodes isn't needed either, and we can close as fixed.