Better warning (JS confirm dialog) when upgrading themes

[demetris]

I see three problems in the current warning:

1. It’s not good UI English: “Upgrading this theme will lose...”

2. It does not follow the layout of similar JS confirm dialogs in WP, which put the OK/Cancel phrase in a second line.

3. It’s not accurate and may frighten people for no reason.

I attach a tentative patch for consideration.

[demetris]

Tentative text tweak for theme upgrade warning

[Denis-de-Bernardy]

+1. patch applies clean, haven't tested though.

[janeforshort]

I think the new text actually makes it slightly more confusing for the end-user. Punting to next cycle b/c we're in string freeze for 2.9, can discuss more then. Would ilke to actually do an audit of all confirmation dialogs, alerts and error messages with 3.0 if possible.

[obenland]

The string now lives in wp-admin/includes/theme.php. It hasn't seen any action in 4 years, can we close this?

[helen]

It has been a long time, and the proposed text doesn't seem any better to me. Can re-open if somebody feels strongly about it.