WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#10101 closed defect (bug) (fixed)

String overlap in plugin editor

Reported by: xibe Owned by: eddieringle
Priority: normal Milestone: 2.8.1
Component: Administration Version: 2.8
Severity: normal Keywords: has-patch tested commit
Cc: eddieringle

Description

In /wp-admin/plugin-editor.php, the 'Browsing XXX.php (active)' string and the 'Select plugin to edit' form are on the same line.

For extensions with long a path and filename, there is a definitive risk to see them overlap. It gets worse with translation that have to use longer words than the original ones (see attached capture)

Attachments (3)

wp-plugineditor-overlap.jpg​ (117.6 KB) - added by xibe 4 years ago.
Capture from original (french reporter).
fixed_plugineditor.png​ (32.2 KB) - added by eddieringle 4 years ago.
Fixed plugin editor
plugineditor-overlap-fix.diff​ (1.2 KB) - added by eddieringle 4 years ago.

Download all attachments as: .zip

Change History (9)

xibe — 4 years ago

Capture from original (french reporter).

comment:1 Denis-de-Bernardy — 4 years ago

  • Keywords needs-patch added

eddieringle — 4 years ago

Fixed plugin editor

eddieringle — 4 years ago

comment:2 eddieringle — 4 years ago

  • Cc eddieringle added
  • Keywords has-patch added; needs-patch removed
  • Owner set to eddieringle
  • Status changed from new to accepted

There's my fix, I tested on a 1024x768 monitor.

comment:3 scribu — 4 years ago

  • Keywords tested commit added

Tested on a 1280 x 800 resolution and it looks alright.

comment:4 azaozz — 4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [11646]) Fix overlap in plugin and theme editors, props eddieringle, fixes #10101 for 2.8

comment:5 azaozz — 4 years ago

(In [11647]) Fix overlap in plugin and theme editors, props eddieringle, fixes #10101 for trunk

comment:6 azaozz — 4 years ago

The patch is pretty similar but instead of adding more CSS it removes some unneeded classes and includes couple more small fixes.

Note: See TracTickets for help on using tickets.