get_option( 'siteurl' ) should return https in some cases

[dawning]

The Issue

When I load up wp-admin under https, I notice in the html source returned, that there are several references to content on my site that are not referenced as https, but rather as http. I believe this bug stems from get_option( 'siteurl' ).

Some Evidence

In one case, the foliopress wysiwyg plugin, the plugin fails to render at all and it seems the offender is a call to get_option( 'siteurl') returning ​http://<correct stuff> rather than ​https://<correct stuff>

Reproduction

I've seen this occur under a few circumstances. Here's some steps to reproduce one of them.

Steps

• Set define ('FORCE_SSL_ADMIN', true); in wp_config.php
• Install ​Foliopress Wysiwyg
• Enable Foliopress & attempt to edit a page (should be forced to connect under https).

Result

You'll find the WYSIWYG won't appear. If you look at the page source, you'll see references to it's components are pointing to ​http:// addresses. This can be traced back to line 167 of foliopress-wysiwyg-class.php

Other Reproductions

I've had this occur without the forced ssl admin directive in wp-admin.php. I find if I just point my browser to the https url of my site, the same effect occurs.

Other Comments

I've tested this both on Windows (running ​WAMP) and on Linux (running Ubuntu/LAMP). Of course that shouldn't make a difference, and it doesn't. The behavior remains in both cases.

Severity

For me this is nearly a blocker level severity, which is why I'm declaring it as "major".

Similar Ticket

• #9008

[ryan]

Use the site_url() function.