Undefined variable: term in wp-includes/taxonomy.php on line 188

[sirzooro]

Notice: Undefined variable: term in C:\wordpress.local\wp-includes\taxonomy.php on line 188

This notice appears when taxonomy does not want query var. Attached patch fixes it.

[westi]

Needs testing.

Moving to future for now.

[sirzooro]

I use this patch on my dev machine and so far I have not found any problems with custom taxonomies because of it.

[markjaquith]

I'd like an explanation of why $term should be removed. It seems like it should be important. :-) I don't want to delete it without knowing why it is considered useless.

Ryan, do you know what's going on here?

[dd32]

I have absolutely no idea what the $term was meant to be for there..

At present, Its operating as it would without it being there.

Since that function has absolutely no idea about the data of the term, it can safely be removed.

That function basically sets it to either:

"issue=" or "taxonomy=issue&term="

which seems like the correct functionality.. as then it'll get substituted as "issue=44" or "taxonomy=issue&term=44" in the query parsing.

[filosofo]

Replying to markjaquith:

I'd like an explanation of why $term should be removed. It seems like it should be important. :-) I don't want to delete it without knowing why it is considered useless.

Ryan, do you know what's going on here?

Why don't you ask Andy? He's the one who wrote it:

​http://core.trac.wordpress.org/attachment/ticket/6357/6357---.diff

[sirzooro]

Any update on this? As @dd32 said, it should work as-is.

[hakre]

Some other warning tickets for Reference: #11435, #11504, #11521

[hakre]

Replying to markjaquith:

I'd like an explanation of why $term should be removed. It seems like it should be important. :-)

Well it's dead simple: It's always undefined / null there. Or can you say why it seems important to you?

[hakre]

Looks like a conflict of assuming validity of code between dd32 and filosofo en contraire of markjaquith (taking only names of core-devs into consideration). I suggest that markjaquith finalizes his statement while taking the comments following his question into account to formulate a new statement.

It should then be more simple for a core dev to decide wether to commit or just to close this ticket as wontfix.

[hakre]

Another warning/notices related ticket: #11606

[dd32]

CC'ing to andy and setting review to andy in the hope of some feedback

[dd32]

(In [13597]) Fix double slashing on /index.phptaxonomy/term/ links. Props Scribu. Fixes #12508. Also Fixes #10445