Use WP HTTP API in IXR_Client

[andy]

IXR_Client calls fsockopen directly. Thus blogs behind proxies can not connect to remote XMLRPC services. To take advantage of the proxy support added in [10692], IXR_Client should use wp_remote_post.

[westi]

+1

This sounds like a good idea.

[josephscott]

+1 as well, I like it. It should see if the wp_remote_post is available and use it as a preference, but fall back to the current behavior.

[andy]

josephscott, wp_remote_post is defined when http.php is included in wp-settings.php. The only user-installed code that could precede that is advanced-cache.php. I don't think it would be worth maintaining the fsockopen code just to ensure the availability of XMLRPC in advanced-cache.php.

[josephscott]

I asked to preserve the code for the sake of this being a 3rd party library and being able to merge changes back. If we make IXR require wp_remote_post then IXR it becomes useless as a 3rd party library. It wasn't a question of the wp_remote_post function being available to IXR at the point in the code execution.

This is something the WordPress has struggled with in many cases. Importing 3rd party libraries and then making hard/impossible to merge changes back. I'd rather not see that happen in this case.

[jacobsantos]

Abstract the HTTP and send that back. If it is abstracted enough, you can replace the IXR HTTP with the WordPress HTTP like in SimplePie.

[ryan]

Refreshed patch

[westi]

I'm going to ensure this makes it into 3.1 :-)

Thanks for the updated patch

[jane]

@westi: Want to check the last patch and make any edits necessary to get it in before 3.1 freeze?

[westi]

(In [16064]) Introduce WP_HTTP_IXR_Client. Extends IXR_Client and switches it to using the WordPress HTTP API instead of fsockopen. See #10588 props andy and ryan.

[westi]

(In [16065]) Switch to using WP_HTTP_IXR_Client in core. See #10588.

[automattor]

(In [16871]) Coding Standards clean-up, Variable typo fix ($errstr), Svn property correction. See #10588