WordPress.org
Get WordPress

Make WordPress Core

Opened 15 years ago

Closed 15 years ago

#10669 closed enhancement (fixed)

Dashboard includes cleanup

Reported by: niallkennedy's profile niallkennedy Owned by:
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.8.4
Component: Administration Keywords: has-patch performance
Focuses: Cc:

Description

Style cleanup of /wp-admin/includes/dashboard.php for speed and consistency.

Single-quote static strings for speed. Ex: '</div>'

Double-quote HTML element attributes for consistency. Ex: "<span class=\"bar\">$foo</span>"

Attachments (1)

dashboard.diff​ (2.1 KB) - added by niallkennedy 15 years ago.
single quotes for static strings

Download all attachments as: .zip

Change History (6)

#1 @niallkennedy
15 years ago

  • Keywords has-patch added

#2 @niallkennedy
15 years ago

  • Milestone changed from Unassigned to 2.8.5
  • Version set to 2.8.4

#3 in reply to: ↑ description @westi
15 years ago

  • Cc westi added
  • Keywords needs-patch added; has-patch removed
  • Milestone changed from 2.8.5 to 2.9

Replying to niallkennedy:

Double-quote HTML element attributes for consistency. Ex: "<span class=\"bar\">$foo</span>"

This is against the WordPress Coding Standards.

Also not 2.8 branch material as this is an enhancement.

The switch to single rather than double quotes for strings that it is appropriate sounds good - could you redo the patch with just those changes please.

@niallkennedy
15 years ago

single quotes for static strings

#4 @niallkennedy
15 years ago

  • Keywords has-patch performance added; markup needs-patch removed

#5 @westi
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11953]) Switch round some quotes. Fixes #10669 props niallkennedy

Note: See TracTickets for help on using tickets.