Opened 4 years ago

Closed 3 years ago

#10715 closed defect (bug) (fixed)

Press This: Can't post without title

Reported by: christoph179 Owned by: noel
Priority: normal Milestone: 2.9
Component: Press This Version: 2.8.4
Severity: normal Keywords: has-patch
Cc:

Description

It is not possible to save or publish a post with an empty title using the press this-bookmarklet.

The post_content-field on line 48 is empty before calling wp_insert_post() on line 51, resulting in an empty_content error when the title-field is left empty.

Attachments (2)

patch.diff​ (654 bytes) - added by christoph179 4 years ago.
press-this-patch.patch​ (1.3 KB) - added by noel 3 years ago.
This fixes titles and also the order of delete and die

Download all attachments as: .zip

Change History (8)

christoph179 — 4 years ago

comment:1   scribu — 4 years ago

  • Keywords has-patch added; posting removed
  • Milestone changed from Unassigned to 2.9

noel — 3 years ago

This fixes titles and also the order of delete and die

comment:2   markjaquith — 3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12361]) Allow for saving Press This entries with blank titles. props noel, christoph179. fixes #10715

comment:3   markjaquith — 3 years ago

(In [12370]) Reverting [12361] due to logic issue. see #10715

comment:4   markjaquith — 3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:5   markjaquith — 3 years ago

The logic issue is that if it is an error, it can't also be a post ID.

comment:6   azaozz — 3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [12371]) Press This empty title fix, props noel, see #11390, fixes #10715

Note: See TracTickets for help on using tickets.