Honor Post Type for Sticky Posts

[chrisscott]

When specifying a post type in WP_Query, sticky posts are added to the beginning of the array regardless of the post_type if specified. The attached patch will restrict the stickies to match the post_type if specified. This is compatible with the multiple post types patch submitted in #10791.

[tott]

The solution looks fine to me but I think the query should run to $wpdb->prepare first.

[ryan]

This will break stickies for regular queries since the post_type is not set for them:

SELECT * FROM wp_posts WHERE wp_posts.ID IN (1611) AND wp_posts.post_type IN ('')

We'll need to set it further up or maybe use the post_type_cap.

[ryan]

prepare() doesn't get along with IN() queries. I think it'll be fine as is since post_type is sanitized.

[ryan]

[12143]

I added an empty string check to get it working.