Ticket #11551 (closed defect (bug): fixed)

Opened 2 years ago

Last modified 2 years ago

Increase download timeout

Reported by: ryan Owned by:
Priority: normal Milestone: 2.9.1
Component: Upgrade/Install Version: 2.9
Severity: normal Keywords:
Cc:

Description (last modified by ryan) (diff)

We've increased it before ([11588]), but those on slow connections are  still having problems. Let's consider bumping the timeout to 5 minutes for download_url() and adding a download_url_timeout filter on that timeout. If we can get better feedback into the installers and upgraders, we might be able to bump it further. Some have reported needing 10 minutes to complete a download.

Attachments

11551.diff Download (530 bytes) - added by ryan 2 years ago.
11551.2.diff Download (491 bytes) - added by ryan 2 years ago.

Change History

comment:1   ryan — 2 years ago

Setting milestone to 2.9.1 for increasing the timeout and adding a filter. Any feedback changes would have to wait for 3.0.

ryan — 2 years ago

comment:2   ryan — 2 years ago

  • Description modified (diff)

comment:3   caesarsgrunt — 2 years ago

+1. The current timeout is hugely irritating...

comment:4   matt — 2 years ago

I would skip the filter for the 0.0.1 release, and question whether it's needed at all.

ryan — 2 years ago

comment:5   ryan — 2 years ago

Patch sans filter.

comment:6   automattor — 2 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [12489]) Increase download_url() timeout to 5 minutes. fixes #11551 for trunk

comment:7   ryan — 2 years ago

(In [12490]) Increase download_url() timeout to 5 minutes. fixes #11551 for 2.9

comment:8   Denis-de-Bernardy — 2 years ago

it probably won't hurt to increase the time limit at the same time.

Note: See TracTickets for help on using tickets.