create a function that does this: wp_get_user_role()

[hakre]

There is an TODO task left in the file wp-admin/user-edit.php around line 196. The original author should decide wether or not he wants to implement the noted feature or to just drop it.

Related Code:

// Get the highest/primary role for this user
// TODO: create a function that does this: wp_get_user_role()
$user_roles = $profileuser->roles;
$user_role = array_shift($user_roles);

[hakre]

code was comitted by ryan.

[hakre]

in [10319] use wp_dropdown_roles(). Props jeremyclarke. fixes #8764

[scribu]

wp_get_user_role() would be really handy. +1

[ericmann]

Adds wp_get_user_role() function that keys off $user_id

[scribu]

Does the patch work for if is_user_logged_in() is false?

[ericmann]

The patch works when is_user_logged_in() is false at least on my installation. I think it could warrant further tests, though, in case I missed something.

[dd32]

Users can have multiple roles. There is no real way to determine which role is the "highest".

I'm proposing we leave this for 3.1, There are a few people who are wanting to clean roles up in 3.1

[wonderboymusic]

I'll see your $user_id and raise you a $user object and then default to $current_user - also implemented the function in more places

[scribu]

We should really get wp_get_user() in: #21120

[scribu]

But other than that, I agree with dd32:

Users can have multiple roles. There is no real way to determine which role is the "highest".

[wonderboymusic]

Semantics - return "first" role - the 3 or 4 places it is used were already arbitrarily returning the first role. I know multiple roles per user per blog exists, but I wish it didn't. Joining user_meta to subdivide users completely breaks at scale (over 1M users, many millions of rows of meta)

[wonderboymusic]

I think the need for this is obsolete. I refreshed the function to return the first role or a passed role if the user has it. But it's only returning the label for the role ('administrator' etc). So the function only returns the first role or does the equiv of a current_user_can - the TODO has been there since the beginning of time: ​http://core.trac.wordpress.org/browser/trunk/wp-admin/user-edit.php?rev=10935#L251 . Moving to 3.6 so it gets used or closed.

[DrewAPicture]

I agree with @wonderboymusic and @dd32. At the least, just remove the TODO, but since users can have multiple roles, this doesn't necessarily return the "highest" role, just the first one. +1 for close.

[ryan]

In 24247:

Remove obsolete TODO.

Props wonderboymusic
fixes #11635