bug in apache_mod_loaded()

[Denis-de-Bernardy]

If apache functions are available, we should not return the default value in apache_mod_loaded().

as things stand, get_mod_rewrite() would return true even if apache_get_modules() says otherwise.

also, phpinfo() is part of php core.

[Denis-de-Bernardy]

tested with apache_get_modules() turned on. needs testing with it off, and with php loaded as cgi.

[dd32]

some webhosts disable phpinfo() when they dont want the users to know the details of the setup.

As crazy as it may sound.

[Denis-de-Bernardy]

patch updated to reflect that.

[sivel]

See also #11604

[sirzooro]

I think it will be good to check this path on setup with PHP Suhosin - I know that this hardening patch adds some protection for phpinfo().

[Denis-de-Bernardy]

sirzooro: I did that already. though again, with the apache loaded function. if suhosin hides the modules, or disables the function, that's fine too. it just returns the default.

my issue with the current code is that it'll return true to get_mod_rewrite() even if apache_get_modules() makes it 100% certain that mod_rewrite is not around.

[ryan]

According to [7508] we return the default on purpose. #6278 doesn't really explain why other than to note it was done to restore the previous default for got_mod_rewrite().

[ryan]

This might explain why we only rely on confirming presence (but not absence) of a mod with apache_get_modules().

​http://core.trac.wordpress.org/ticket/11604#comment:3

[Denis-de-Bernardy]

yeah. and hakre mentioned that in a fast cgi environment, it's pretty much impossible to detect an aapche module using simple functions.

I think we should consider applying different logic for get_mod_rewrite(). Here's what I just committed to the health-check plugin:

​http://plugins.trac.wordpress.org/changeset/192787/health-check

[nacin]

Tools > Network uses both got_mod_rewrite() and apache_mod_loaded() rather effectively. I don't think we should add much more to core for this. I think the perfect place for the code in the health check plugin is the health check plugin.