add_category_form_fields Action Fires Twice

[blepoxp]

The add_category_form_fields action fires twice in /wp-admin/edit-tags.php on line 341 - 345 in trunk with r. 13020.

This seems to happen because add_category_form_fields gets called and then 'add_' . $taxonomy . '_form' gets called.

I can submit a patch once I know which do_action needs to be removed.

if ( 'category' == $taxonomy )
	do_action('edit_category_form',	(object)array('parent' => 0) );
else
	do_action('add_tag_form', $taxonomy);
do_action('add_' . $taxonomy . '_form', $taxonomy);

Better patch.

Added a second patch to prevent add_tag_form_fields from firing twice in case a taxonomy called "tag" is registered.

A few things can be done here, However, I'm wondering if it'd be best to rename the new hook to avoid the conflict instead.

Eg, Change it from do_action('add_' . $taxonomy . '_form_pre', $taxonomy); to do_action($taxonomy . '_add_form_pre', $taxonomy);

This'd allow for the new generic hook to apply to categories, whilst also having the backwards compat for the old category actions args the same.

The reasoning for the renaming, is to allow for the current category hooks to continue to operate, however provide a exact and known hook for all future plugin developers to rely on (without having to add a special function to handle the category hook)

Correct, I'm going through and running into problems at the hooks starting at L 292, which are the ones included above (though not the action referred to in the ticket summary).

Throwing up the third patch to address the other code blocks. I agree with renaming so I'll include that as well.

Addresses some more collisions

I've got a hybrid of mine and nacin's code running locally which i'll finish testing later today.

(In [13035]) Rename new taxonomy page hooks to prevent hook conflicts. See #12171

Give that a whirl, and see if it provides a good enough support. All previous hooks should be working the same as they were before.