Parent term count

[jfarthing84]

Hierarchical term parents (including categories) count stays at 0 when using child terms. This results in a 404 error when trying to pull up the term/category page for a parent term which has children with posts.

---

When viewing a Parent term of a custom taxonomy, Objects in the children of the term are not shown.

[jfarthing84]

It seems this is just affecting hierarchical custom taxonomies (which is still just as important).

[jfarthing84]

Upon even further investigation, if you pull up an empty custom taxonomy (hierarchical or not), you get a 404 error rather than the default page displaying "No posts found" which would display if you pulled up an empty category.

[dd32]

(In [13615]) Don't 404 for empty custom taxonomy terms. See #12533

[jfarthing84]

Thanks. You will also have to add the 'hide_empty=>false' flag to the is_tax section og WP_Query::get_queried_object().

Also, there still is a problem with custom hierarchical taxonomies.

[dd32]

Thanks. You will also have to add the 'hide_empty=>false' flag to the is_tax section og WP_Query::get_queried_object().

The changeset doesnt show it very well, but thats where it is.

Hierarchical term parents (including categories) count stays at 0 when using child terms.

This depends on if the arg 'pad_counts' is set or not, By default, its not. Where are you seeing it not being reported correctly?

[jfarthing84]

Forget the count. I was just saying, it is not taking child terms into account at all.

Look at how categories are handled and then look at how taxonomies are handled. You'll clearly see that the taxonomy handling lacks any support for hierarchical taxonomies.

[dd32]

Look at how categories are handled and then look at how taxonomies are handled. You'll clearly see that the taxonomy handling lacks any support for hierarchical taxonomies.

Are you saying, That visiting /tax/parent/ is not showing posts in /tax/parent/child/ too? - Sorry, I didnt quite understand that in the original ticket description.

Showing the children always confused me, but i can see why it would be required.

[jfarthing84]

Yea, exactly.

Say you are using something like this:

United States

• Alabama
• Alaska
• Etc...

In most cases, you will only assign a post to one of the child terms. Then, if you visit the parent term (you wanted to see all pots in the US), you should see ALL child posts.

[scribu]

Replying to jfarthing84:

Say you are using something like this:

United States

• Alabama
• Alaska
• Etc...

In most cases, you will only assign a post to one of the child terms. Then, if you visit the parent term (you wanted to see all pots in the US), you should see ALL child posts.

Agreed.

[jfarthing84]

wp-includes/query.php

[jfarthing84]

So, this is ready to go, no?

[scribu]

bring in empty terms only for hierarchical taxonomies

[scribu]

beautification

[scribu]

12533.2.diff:

• bring in empty terms only for hierarchical taxonomies

• replace a count() check with !empty()

12533.3.diff:

• remove redundant whitespace

[scribu]

Previous patches did not handle the case where $qtaxonomy? was empty.

This is fixed in 12533.4.diff

[dd32]

This is fixed in 12533.4.diff

Patch looks good overall, I'll add it to the testing queue.

[dd32]

(In [13787]) When viewing a Parent term in a hierarchical taxonomy, display objects contained within children too. Props scribu. Fixes #12533

[scribu]

It should have been "Props jfarthing84, scribu", since he submitted the initial patch. Oh well...

[dd32]

It should have been "Props jfarthing84, scribu",

My apologies to jfarthing84, I didnt realise he'd submitted the first patch when committing.

[jfarthing84]

I was going to say that. But yeah, "Oh well."