Opened 3 years ago
Closed 3 years ago
#12853 closed defect (bug) (fixed)
uploading in Multisite over quota results in "Http Error"
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.0 |
| Component: | Upload | Version: | |
| Severity: | normal | Keywords: | multisite ui-feedback |
| Cc: |
Description
When in Multisite mode, If you attempt to upload a file that will take you over your usage quota (For example, a 30MB file with the default 10MB limit), the upload will start, and finish with a "HTTP Error" error message.
Expected result: Either the upload would be prevented if the file will take it over the limit, or a error message explaining that they've used up their quota should show.
Attachments (1)
Change History (24)
You can't check filesize before uploading with the browser uploader. I think it's possible with the flash uploader but it would be a major rewrite.
Its possible with the flash uploader, it specifically has a parameter to specify the maximum filesize uploadable, At present, this is set to the hosts maximum upload size.
This ticket has a 2 pronged attack,
- The error message shown is non-descriptive, it should mention the fact that they dont have enough quota
- It shouldnt allow files greater than min(server_limit, user_limit) from being uploaded.
comment:10
wpmuguru — 3 years ago
comment:11
ocean90 — 3 years ago
We get also a HTTP Error when check_admin_referer() fails and when the file size is higher then the allowed file size (ms-options.php).
Both because of the wp_die().
comment:12
wpmuguru — 3 years ago
comment:13
ocean90 — 3 years ago
[14694] works fine. You need also patch from #12225. Then it looks like this http://grab.by/4pf1
comment:14
ocean90 — 3 years ago
In 12853.patch I want to show you my idea. I introduced ASYNC_UPLOAD. If ASYNC_UPLOAD is true, don't use wp_die() and only return $file. Then let wp_handle_upload() handle the error message.
comment:15
wpmuguru — 3 years ago
comment:17
wpmuguru — 3 years ago
- Resolution set to fixed
- Status changed from new to closed
If there is still an issue, someone can re-open.
comment:18
dd32 — 3 years ago
- Keywords ux-feedback added
- Resolution fixed deleted
- Status changed from closed to reopened
comment:19
dd32 — 3 years ago
[14693] - That is a bit too bold IMO, That is something thats better suited to a small paragraph text below the upload buttons, I've added ui-feedback in hope someone will come up with some better wording and/or location..
comment:20
dd32 — 3 years ago
comment:21
dd32 — 3 years ago
- Keywords ui-feedback added; ux-feedback removed
Changed it from a header to a paragraph text. Does anyone object to that, have better wording, or a better location for it?
comment:22
johnonolan — 3 years ago
Nope, I think it works better as paragraph text!
comment:23
ryan — 3 years ago
- Resolution set to fixed
- Status changed from reopened to closed

uploading smaller files does of course succeed. I see there are some strings that are supposed to convey this error message already, unsure of why they're not showing up.