Opened 3 years ago

Closed 3 years ago

#12853 closed defect (bug) (fixed)

uploading in Multisite over quota results in "Http Error"

Reported by: dd32 Owned by:
Priority: normal Milestone: 3.0
Component: Upload Version:
Severity: normal Keywords: multisite ui-feedback
Cc:

Description

When in Multisite mode, If you attempt to upload a file that will take you over your usage quota (For example, a 30MB file with the default 10MB limit), the upload will start, and finish with a "HTTP Error" error message.

Expected result: Either the upload would be prevented if the file will take it over the limit, or a error message explaining that they've used up their quota should show.

Attachments (1)

12853.patch (957 bytes) - added by ocean90 3 years ago.

Download all attachments as: .zip

Change History (24)

comment:1   dd323 years ago

uploading smaller files does of course succeed. I see there are some strings that are supposed to convey this error message already, unsure of why they're not showing up.

You can't check filesize before uploading with the browser uploader. I think it's possible with the flash uploader but it would be a major rewrite.

comment:3   dd323 years ago

Its possible with the flash uploader, it specifically has a parameter to specify the maximum filesize uploadable, At present, this is set to the hosts maximum upload size.

This ticket has a 2 pronged attack,

  1. The error message shown is non-descriptive, it should mention the fact that they dont have enough quota
  2. It shouldnt allow files greater than min(server_limit, user_limit) from being uploaded.

(In [14420]) limit upload size to site's available limit, see #12853

(In [14421]) use filter vs action in 14420, see #12853

(In [14437]) @since for some new ms functions re: upload file size limits. see #12853.

We need to still handle the error message aspect, if possible.

(In [14682]) show upload limit in media upload UI, see #12853

That could do with some CSS or <h#> tags.

(In [14693]) boldly go where no man has gone before, see #12853

We get also a HTTP Error when check_admin_referer() fails and when the file size is higher then the allowed file size (ms-options.php).

Both because of the wp_die().

(In [14694]) observe fileupload_maxk in media uploader, see #12853

[14694] works fine. You need also patch from #12225. Then it looks like this http://grab.by/4pf1

ocean903 years ago

In 12853.patch I want to show you my idea. I introduced ASYNC_UPLOAD. If ASYNC_UPLOAD is true, don't use wp_die() and only return $file. Then let wp_handle_upload() handle the error message.

(In [14716]) only die on async upload error, see #12853

(In [14717]) die in non-async upload in [14716], see #12853

  • Resolution set to fixed
  • Status changed from new to closed

If there is still an issue, someone can re-open.

  • Keywords ux-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

[14693] - That is a bit too bold IMO, That is something thats better suited to a small paragraph text below the upload buttons, I've added ui-feedback in hope someone will come up with some better wording and/or location..

(In [14776]) We're not as bold as some people make us out to be. Move the maximum upload size from a Heading to a paragraph text. Fix screen formatting on Multisite when over quota. see #12853

  • Keywords ui-feedback added; ux-feedback removed

Changed it from a header to a paragraph text. Does anyone object to that, have better wording, or a better location for it?

Nope, I think it works better as paragraph text!

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.