New menu systems unrecoverable error

[Dickie]

I had one of the new menu system set up that included a set of categories.
I then decided to delete some of the categories (in the category menu) that were still included in the menu, and now get the following error message on the menu admin screen, (and the front end as well) with no option to delete the offending menu or create a new one.

Catchable fatal error: 
Object of class WP_Error could not be converted to string in
/home/*******/public_html/wp-includes/formatting.php on line 433

I tried re-adding the categories that I deleted, but to no avail. It looks like I may need to delve into the database to fix this one.

[Dickie]

Replicatable steps...

Create a category... add it to a new menu...
Delete the category.
Go back to menu editor.

Bang

[ptahdunbar]

nav_menu_items_auto_delete.diff fixes this bug by deleting any instances of an object (category, page, post, etc.) from all nav menus when they are removed from the db.

[nacin]

If a post gets deleted and a menu item is a term with the same ID as the post, it accidentally gets the axe.

We don't account for trashed posts. I've additionally moved the actions to the post-delete actions (deleted_post versus delete_post). And we need to call wp_delete_post with a $force_delete arg.

Wouldn't this cause a potential loop? i.e. if the function needs to delete a nav_menu_item post, then it'll fire all the hooks all over again for that. We need a way to stop that.

Posting my patch so far.

[nacin]

Aside from that, I forgot to mention one of the more important notes. In this patch, we would be looping through every menu item of every menu and pulling up to two post meta values before actually deleting anything. I think this could justify direct queries.

[nacin]

I think this one was handled elsewhere. Re-open with a new report.

[koopersmith]

Tested, and works for me. Fixed.

[pearsonified]

I just tested this with custom taxonomies on 3.0.1, and it failed. It looks as though categories and tags were fixed, but a slight adjustment will be necessary to accommodate the deletion of taxonomies.

[mrmist]

Version should track the original bug report.

[nacin]

Replying to pearsonified:

I just tested this with custom taxonomies on 3.0.1, and it failed. It looks as though categories and tags were fixed, but a slight adjustment will be necessary to accommodate the deletion of taxonomies.

Do you mean the removal of terms in custom taxonomies, or the unregistration of a taxonomy? The latter is a separate bug report, #13958.

[nacin]

No response, re-closing as fixed.