Simplify and add filtering to call to display author for media

[sbressler]

The author displayed on the media page (upload.php) is not filterable in any way currently. This patch adds a filter for the author ('media_author'). Perhaps more filters should be added for other fields, but at the least I would like to add this filter.

It looks like there are already filters that can be leveraged for this.

Perhaps I'm missing something, but which? The only other one I see in upload.php or edit-attachment-rows.php is 'media_row_actions', but that's specifically for the actions available to something in the media library I think.

the_author and get_the_author have filters.

Doesn't look like the direct setup_userdata call can be changed easily. That said, if you want to filter the entire column, why not remove the column and add your own?

Leaving in 3.1 for sure as that's the earliest we're going to touch media/upload. When we do, we're likely going to break a lot, and we don't want more filters in place we need to at least consider back compat for.

Well, one could filter 'the_author' and/or 'get_the_author_display_name', which actually does seem like a better idea than adding this filter. However, then the code in upload.php should probably be changed to use the_author or run through the filter instead of echoing $author->display_name. Thoughts?

Thanks for the feedback, nacin. I was making this much harder than I realized. Now I would just propose simplifying the way the author is called for unattached media.

Call the_author for unattached media just like attached media

Future release for now, as these need refresh against trunk due to the list tables.

Refresh for WordPress 3.1 with list-table-media.

Added a refreshed patch. Should be good to go for 3.1.

Use WP functions to generate URL (per Nacin's request)

Again, a refreshed patch for the changes to trunk.

I hope that the above patch can be committed soon so I can stop refreshing it :)

Just tested this on tip of trunk and the latest patch (13235.6.diff) still works great. However, I realized that it no longer achieves the purpose I was hoping. While the author text displayed can be filtered using the standard 'the_author' filter, the href added cannot be filtered as desired. Any ideas for how this could be achieved properly? Would adding a separate filter like originally proposed (first patch uploaded) be that bad an idea?

Would like to get this in before 3.2 freeze so I can stop thinking about this year-old ticket.