wp_nav_menu current-menu-item incorrect

[jolley_small]

When a page ID is the same as a category ID, and both the page and category are placed in a menu, both items will be given current-menu-item which is incorrect.

Issue exists in beta 1/2.

[duck_]

Couldn't find a function to help make this nicer, maybe someone else knows of one... anyway gives the idea of the fix.

[nacin]

We could probably just do ( $item->type == 'post_type' && $wp_query->is_singular ) || $item->type == 'taxonomy' && ! $wp_query->is_singular ). Haven't looked at the code yet but if we need to use $wp_query then that'd be easiest and should be good.

[banago]

Replying to duck_:

Couldn't find a function to help make this nicer, maybe someone else knows of one... anyway gives the idea of the fix.

It's pretty nice already - Let's hope it will be committed to 3.0.

[nacin]

(In [14824]) Proper checks for current-menu-item. props duck_, fixes #13409.