Empty Site Title issues

[mrmist]

If your site has no "site title" in Settings, then the "visit site" link in the admin header is an invisible (though still available) link.

I think one of the following is needed -

1. A blank "Site Title" is not allowed through Settings.

or

2. If the "Site Title" is blank, there should be some default text placed into the "visit site" link, so that it has some visible content.

or

3. Both 1 & 2.

Add visit site to the site header.

Admin header patch

Ahh I see you also created a patch... Mine is slightly different because I wasn't sure if the ' ' value was used elsewhere for other things, so I only altered the actual link text.

Well, we could make it so that the user couldn't even submit a blank site title if they wanted. But, we should wait until one of the big devs stops by to offer some insight. :D

Try this on for size.

This will redirect the user back to options-general.php if the site title is blank. And it adds in your patch since it would cause less issues in other areas of the site.

We currently account for blogname to be , based on the code seen in the first diff. So I'm not sure if we necessarily need to block empty values there.

Setting it to "Visit Site" instead of " " seems like it'll make sense. Though that would need to be translated. It's not a new string as "Visit Site" is used in the title attribute there, so we can probably add this to 3.0.1.

I created this patch before I realized anyone else was working on it... so I'm just submitting it cause I create it.

Attaching my patch from #15120.

Running off revision 15805. Replaces   with ( 'Visit Site' );

It was previously nbsp because we had the small "Visit Site" button before 3.0.

I think we can go to "Visit Site". Alternatively, we could go to "WordPress".

@nacin: why would we go with "WordPress" for a visit site link? Visit site.

(In [15992]) Use 'Visit Site' in header if blog has no name. props blepoxp, fixes #13978.