Opened 3 years ago

Closed 6 weeks ago

#14130 closed enhancement (wontfix)

Better gallery shortcode filter

Reported by: johnbillion Owned by:
Priority: normal Milestone:
Component: Shortcodes Version: 3.0
Severity: normal Keywords: has-patch close
Cc: carstenbach, TomAuger, jeremy.felt@…, desrosj@…

Description

There's a filter inside gallery_shortcode() which allows plugins to override the default gallery template ('post_gallery'), but it's called at the beginning of the function before we've fetched our gallery images. If a plugin uses this filter, it has to perform a lot of logic to determine the post gallery images.

We should add a second filter to gallery_shortcode() after we've determined our gallery images, to make plugin authors' jobs easier.

Attachments (1)

14130.patch​ (546 bytes) - added by johnbillion 3 years ago.

Download all attachments as: .zip

Change History (10)

johnbillion — 3 years ago

comment:1   johnbillion — 3 years ago

  • Keywords has-patch added

Patch which adds a 'post_gallery_output' filter.

Similar filter to 'post_gallery' found on line 763 of same file, but we include a second parameter with our array of attachments.

comment:2   nacin — 3 years ago

  • Milestone changed from Awaiting Review to Future Release

comment:3   carstenbach — 19 months ago

  • Cc carstenbach added

comment:4   TomAuger — 15 months ago

  • Cc TomAuger added

comment:5   ocean90 — 15 months ago

Duplicate: #20230

comment:6   jeremyfelt — 15 months ago

  • Cc jeremy.felt@… added

comment:7   desrosj — 10 months ago

  • Cc desrosj@… added

comment:8   johnbillion — 3 months ago

  • Keywords close added

No traction on this in 3 years. Suggest wontfix. Whatever method I used to get around this at the time must have worked fine.

comment:9   johnbillion — 6 weeks ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.