#14163 closed enhancement (fixed)
Extend comment search to support user_id as argument
Reported by: | neoxx | Owned by: | scribu |
---|---|---|---|
Milestone: | 3.1 | Priority: | normal |
Severity: | normal | Version: | 3.0 |
Component: | Comments | Keywords: | gsoc has-patch |
Focuses: | Cc: |
Description (last modified by )
Hi,
what do you think about the idea of extending _wp_get_comment_list
in wp-admin/includes/template.php in a way that we can also query for user-ids?
I know, that the user_id will only be stored for comments of logged-in users, though I would need this search functionality not only, but also for my count-comments plugin. Currently, I implemented a link from users.php to edit-comments.php using
?s=user_display_name
which obviously results in missed comments as well as false positives.
Just to give the idea a start, I've attached a patch prototype that extends handling of $_REQUEST['s']
. - Or would we prefer a separate argument?
Attachments (1)
Change History (12)
#1
@
14 years ago
- Description modified (diff)
- Keywords gsoc added; comments comment user removed
- Milestone changed from Awaiting Review to Future Release
- Owner set to scribu
- Status changed from new to assigned
#2
@
14 years ago
Here is how it is currently:
http://gsoc.trac.wordpress.org/browser/2010/scribu/wp-admin/includes/list-tables.php?rev=542#L670
#3
@
14 years ago
That's good to know. - Imho the best way would be to have the 'user_id' query-able by a $_REQUEST variable handed over to users.php (same as edit.php?author=nn for posts).
#6
@
14 years ago
- Milestone changed from Future Release to 3.1
- Resolution set to fixed
- Status changed from assigned to closed
#7
@
14 years ago
nice update :) but how is it now possible to query for the user-id with a $_REQUEST-parameter?
#8
@
14 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
- Type changed from feature request to enhancement
As part of my GSoC project, I have removed _wp_get_comment_list() in favor of get_comments(), which already has a 'user_id' argument.