WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Closed 11 years ago

Last modified 11 years ago

#14754 closed defect (bug) (wontfix)

add_query_arg() refactoring

Reported by: hakre's profile hakre Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:

Description

The function add_query_arg() looks like that it could benefit from a refactoring. Especially the handling of optional parameters (did introduce PHP 4 that language feature?) can benefit by a sligh touch-up.

Attached patch reflects only the first few lines of the function.

Attachments (2)

14754.patch​ (1.2 KB) - added by hakre 14 years ago.
14754.2.patch​ (1.8 KB) - added by hakre 14 years ago.
some more lines

Download all attachments as: .zip

Change History (6)

@hakre
14 years ago

@hakre
14 years ago

some more lines

#1 @westi
14 years ago

  • Keywords needs-unit-tests added
  • Milestone changed from Awaiting Review to Future Release

How has this been tested?

Could you write some unit-test cases for this?

#3 @c3mdigital
11 years ago

  • Keywords close removed
  • Resolution set to wontfix
  • Status changed from new to closed

This seems like refactoring for the sake of refactoring. Is there a reason why we shouldn't be using func_get_args?

#4 @SergeyBiryukov
11 years ago

  • Keywords needs-patch needs-unit-tests removed
  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.