Opened 3 years ago

Last modified 2 years ago

#14754 new defect (bug)

add_query_arg() refactoring

Reported by: hakre Owned by:
Priority: normal Milestone: Future Release
Component: General Version:
Severity: normal Keywords: needs-patch needs-unit-tests close
Cc:

Description

The function add_query_arg() looks like that it could benefit from a refactoring. Especially the handling of optional parameters (did introduce PHP 4 that language feature?) can benefit by a sligh touch-up.

Attached patch reflects only the first few lines of the function.

Attachments (2)

14754.patch​ (1.2 KB) - added by hakre 3 years ago.
14754.2.patch​ (1.8 KB) - added by hakre 3 years ago.
some more lines

Download all attachments as: .zip

Change History (4)

hakre — 3 years ago

hakre — 3 years ago

some more lines

comment:1   westi — 2 years ago

  • Keywords needs-unit-tests added
  • Milestone changed from Awaiting Review to Future Release

How has this been tested?

Could you write some unit-test cases for this?

Note: See TracTickets for help on using tickets.