Opened 3 years ago

Closed 2 years ago

#14816 closed defect (bug) (fixed)

Optimise dynamic_sidebar

Reported by: hakre Owned by:
Priority: normal Milestone: 3.2
Component: Widgets Version: 3.1
Severity: normal Keywords: has-patch 3.2-early commit
Cc:

Description (last modified by westi)

Rasmus Lerdorf did some changes to Wordpress for a hphp compilation / performance presentation.

dynamic_sidebar can get out early if there are no sidebars.

Attachments (1)

14816-widgets.patch​ (509 bytes) - added by hakre 3 years ago.
Shortcut.

Download all attachments as: .zip

Change History (7)

hakre — 3 years ago

Shortcut.

comment:1   hakre — 3 years ago

Full diff is here: ​http://progphp.com/wp/ (​More Info), dynamic_sidebar can get out early if there are no sidebars.

Just scanning and providing patches for the places I see fit but as I found later out:

Rest seems to be already fixed.

Last edited 2 years ago by hakre (previous) (diff)

comment:2   hakre — 3 years ago

And if not, probably already reported, like the constructor stuff from the presentation: #10861

comment:3   hakre — 3 years ago

Related: #14429
Related: [15639]
Related: [15637]
Related: [13684]

comment:4   westi — 2 years ago

  • Component changed from General to Widgets
  • Description modified (diff)
  • Keywords has-patch 3.2-early commit added
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from Diverse Stuff from Rasmus Lerdorfs Patch to Optimise dynamic_sidebar
  • Version set to 3.1

comment:5   nacin — 2 years ago

  • Milestone changed from Future Release to 3.2

comment:6   nacin — 2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17545]) Bail early in dynamic_sidebar() if there are no sidebars. fixes #14816.

Note: See TracTickets for help on using tickets.