#14900 closed enhancement (fixed)
link-template string builder cleanup
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | has-patch |
Focuses: | template | Cc: |
Description
Convert dynamic strings to static strings where quick wins are available.
Wrap output such as translated strings in an esc_attr or esc_html just in case HTML can better handle what a parent page's character encoding can't.
Attachments (1)
Change History (9)
#1
@
15 years ago
- Component changed from Permalinks to Template
Looks good to me so far. One thing of note is that I have the feeling the change of 'esc_url_raw' to 'esc_url' in the final patch chunk there may be wrong..
#2
@
14 years ago
- Milestone changed from Awaiting Review to Future Release
Don't forget about the translation-enabled escaping functions, like esc_attr__()
!
#5
@
10 years ago
- Owner set to wonderboymusic
- Resolution set to fixed
- Status changed from new to closed
In 34444:
#7
@
10 years ago
Noting that r34444 broke the Edit links in Twenty Sixteen. https://github.com/WordPress/twentysixteen/issues/259
Had been using:
edit_post_link( sprintf( /* translators: %s: Name of current post */ __( 'Edit %s', 'twentysixteen' ), the_title( '<span class="screen-reader-text">', '</span>', false ) ), '<span class="edit-link">', '</span>'
Note: See
TracTickets for help on using
tickets.
staticize strings. escape some strings for HTML output.