WordPress.org

Ready to get started?Download WordPress

Make WordPress Core

Opened 3 years ago

Last modified 3 years ago

#14900 new enhancement

link-template string builder cleanup

Reported by: niallkennedy Owned by:
Priority: normal Milestone: Future Release
Component: Template Version:
Severity: normal Keywords: has-patch
Cc:

Description

Convert dynamic strings to static strings where quick wins are available.

Wrap output such as translated strings in an esc_attr or esc_html just in case HTML can better handle what a parent page's character encoding can't.

Attachments (1)

link-template.diff​ (5.8 KB) - added by niallkennedy 3 years ago.
staticize strings. escape some strings for HTML output.

Download all attachments as: .zip

Change History (3)

niallkennedy — 3 years ago

staticize strings. escape some strings for HTML output.

comment:1 dd32 — 3 years ago

  • Component changed from Permalinks to Template

Looks good to me so far. One thing of note is that I have the feeling the change of 'esc_url_raw' to 'esc_url' in the final patch chunk there may be wrong..

comment:2 markjaquith — 3 years ago

  • Milestone changed from Awaiting Review to Future Release

Don't forget about the ​translation-enabled escaping functions, like esc_attr__()!

Note: See TracTickets for help on using tickets.