Opened 3 years ago

Closed 3 years ago

#14945 closed enhancement (fixed)

No link to OEmbeded images

Reported by: markjaquith Owned by:
Priority: normal Milestone: 3.1
Component: General Version: 3.0.1
Severity: normal Keywords: has-patch commit
Cc:

Description

When we use OEmbed to insert an image, we just do an image tag. No link to the image page. This violates Flickr's terms of service (and might violate others). It also eliminates some potentially useful information that might be on that page. Comments, notes, etc. We should wrap the image in the URL provided.

Attachments (1)

14945.diff​ (720 bytes) - added by markjaquith 3 years ago.

Download all attachments as: .zip

Change History (5)

markjaquith — 3 years ago

comment:1   markjaquith — 3 years ago

  • Milestone changed from Awaiting Review to 3.1
  • Version changed from 3.1 to 3.0.1

comment:2   sorich87 — 3 years ago

  • Keywords has-patch added

comment:3   nacin — 3 years ago

  • Keywords commit added

comment:4   nacin — 3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16444]) When inserting an image via oEmbed, wrap it in a link. props MarkJaquith, fixes #14945.

Note: See TracTickets for help on using tickets.