Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#15104 closed defect (bug) (worksforme)

Inefficient building of Quick Edit Author select tag

Reported by: kdnewton's profile kdnewton Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Performance Keywords: edit.php author select users quick edit
Focuses: Cc:

Description

When dealing with a wp_users table with 37000+ records, the edit.php response is almost 4MB in size.

<label><span class="title">Author</span><select name='post_author' class='authors'>
	<option value='1'>admin</option>
	<option value='2'>kdnewton</option>
</select></label>

Imagine 37000+ options in that list. Perhaps the list can be generated when needed? Or an option to turn off quick edit?

Change History (5)

#1 follow-up: @nacin
14 years ago

Has this been tested on 3.1?

I know we're not going to improve the raw HTML without allowing that to be disabled, but performance should be improved.

#2 in reply to: ↑ 1 @kdnewton
14 years ago

Replying to nacin:

Has this been tested on 3.1?

I know we're not going to improve the raw HTML without allowing that to be disabled, but performance should be improved.

Yessir. Taken from the header

<meta
name="generator" content="WordPress 3.0.1" />

Additionally, the jquery on the page never seems to complete when there are so many options in the select.

A script on this page may be busy, or it may have stopped responding. You can stop the script now, open the script in the debugger, or let the script continue.

Script: http://uberarticles.com/wp-includes/js/jquery/jquery.js?ver=1.4.2:47

#3 follow-up: @nacin
14 years ago

Sorry, I mean 3.1-alpha, current trunk -- not 3.0.1, the latest stable.

#4 in reply to: ↑ 3 @kdnewton
14 years ago

Replying to nacin:

Sorry, I mean 3.1-alpha, current trunk -- not 3.0.1, the latest stable.

Thank you kindly! I've now tested with the 3.1-alpha (the nightly build) and the issue appears to have been taken care of. The huge select was not generated.

I'd close the ticket myself, or mark as 'worksforme' but I don't know if that's something I'm supposed to do as a bug reporter.

#5 @Denis-de-Bernardy
14 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.