Opened 3 years ago

Closed 2 years ago

#15236 closed defect (bug) (duplicate)

Delete plugin confirmation should strip_tags from plugin author

Reported by: ampt Owned by:
Priority: normal Milestone:
Component: Plugins Version: 3.1
Severity: trivial Keywords: has-patch
Cc:

Description

On the plugins page if I click delete Hello Dolly the confirmation page displays:

You are about to remove the following plugin:

  • Hello Dolly by <a href="​http://ma.tt/" title="Visit author homepage">Matt Mullenweg</a>

The attached patch strips tags from the plugin author before outputting to the browser

Attachments (2)

15236.patch​ (1.2 KB) - added by ampt 3 years ago.
15236.2.diff​ (645 bytes) - added by ampt 3 years ago.

Download all attachments as: .zip

Change History (5)

ampt — 3 years ago

comment:1   nacin — 3 years ago

  • Milestone changed from Awaiting Review to 3.1

Hmm. We shouldn't need to strip HTML there. We should have Author_Name without the link for get_plugin_data(), the same thing we did for themes in [14658].

The problem here is a change in functionality in either 2.9 or 3.0, for Author to include the link by default. We just didn't update it across core.

ampt — 3 years ago

comment:2   ampt — 3 years ago

Thanks nacin, attached is another patch with that fixes this with get_plugin_data

comment:3   nacin — 2 years ago

  • Milestone 3.1 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

#15662

Note: See TracTickets for help on using tickets.